From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2205) id 4D3E03857C73; Mon, 5 Oct 2020 12:20:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4D3E03857C73 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Tom de Vries To: gcc-cvs@gcc.gnu.org Subject: [gcc r11-3654] [omp, ftracer] Remove incorrect suggestion in ignore_bb_p X-Act-Checkin: gcc X-Git-Author: Tom de Vries X-Git-Refname: refs/heads/master X-Git-Oldrev: f33a43f9f7eab7482837662821abb7fd02cb4350 X-Git-Newrev: fc998c21c2c49e06cd4e548cd0d21ef25c880dbc Message-Id: <20201005122034.4D3E03857C73@sourceware.org> Date: Mon, 5 Oct 2020 12:20:34 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Oct 2020 12:20:34 -0000 https://gcc.gnu.org/g:fc998c21c2c49e06cd4e548cd0d21ef25c880dbc commit r11-3654-gfc998c21c2c49e06cd4e548cd0d21ef25c880dbc Author: Tom de Vries Date: Mon Oct 5 14:03:34 2020 +0200 [omp, ftracer] Remove incorrect suggestion in ignore_bb_p In commit ab3f4b27abe "[omp, ftracer] Don't duplicate blocks in SIMT region" I added a comment in ignore_bb_p suggesting a reordering of SIMT_VOTE_ANY and SIMT_EXIT, which is not possible since VOTE_ANY may have data dependencies to storage that is deallocated by SIMT_EXIT. I've now opened a PR (PR97291) to describe the problem the reordering was intended to fix. Remove the incorrect suggestion. gcc/ChangeLog: 2020-10-05 Tom de Vries * tracer.c (ignore_bb_p): Remove incorrect suggestion. Diff: --- gcc/tracer.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/gcc/tracer.c b/gcc/tracer.c index 5e51752d89f..5ee66511f8d 100644 --- a/gcc/tracer.c +++ b/gcc/tracer.c @@ -115,10 +115,8 @@ ignore_bb_p (const_basic_block bb) /* An IFN_GOMP_SIMT_ENTER_ALLOC/IFN_GOMP_SIMT_EXIT call must be duplicated as part of its group, or not at all. - The IFN_GOMP_SIMT_VOTE_ANY is currently part of such a group, - so the same holds there, but it could be argued that the - IFN_GOMP_SIMT_VOTE_ANY could be generated after that group, - in which case it could be duplicated. */ + The IFN_GOMP_SIMT_VOTE_ANY is part of such a group, so the same holds + there. */ if (is_gimple_call (g) && (gimple_call_internal_p (g, IFN_GOMP_SIMT_ENTER_ALLOC) || gimple_call_internal_p (g, IFN_GOMP_SIMT_EXIT)