From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2181) id 9D6553850424; Wed, 4 Nov 2020 23:41:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9D6553850424 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Jonathan Wakely To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org Subject: [gcc r11-4729] libstdc++: Fix default mode of new basic_stringstream constructor [PR 97719] X-Act-Checkin: gcc X-Git-Author: Jonathan Wakely X-Git-Refname: refs/heads/master X-Git-Oldrev: 4d76079fdfa3d36ebd95ac8b489519945e8ee88f X-Git-Newrev: 8f565d255a3157828e45f8b9844b3d156193c182 Message-Id: <20201104234111.9D6553850424@sourceware.org> Date: Wed, 4 Nov 2020 23:41:11 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Nov 2020 23:41:11 -0000 https://gcc.gnu.org/g:8f565d255a3157828e45f8b9844b3d156193c182 commit r11-4729-g8f565d255a3157828e45f8b9844b3d156193c182 Author: Jonathan Wakely Date: Wed Nov 4 21:44:05 2020 +0000 libstdc++: Fix default mode of new basic_stringstream constructor [PR 97719] libstdc++-v3/ChangeLog: PR libstdc++/97719 * include/std/sstream (basic_stringstream(string_type&&, openmode)): Fix default argument. * testsuite/27_io/basic_stringstream/cons/char/97719.cc: New test. Diff: --- libstdc++-v3/include/std/sstream | 2 +- .../27_io/basic_stringstream/cons/char/97719.cc | 40 ++++++++++++++++++++++ 2 files changed, 41 insertions(+), 1 deletion(-) diff --git a/libstdc++-v3/include/std/sstream b/libstdc++-v3/include/std/sstream index 33a00486606..8acf1eb259a 100644 --- a/libstdc++-v3/include/std/sstream +++ b/libstdc++-v3/include/std/sstream @@ -976,7 +976,7 @@ _GLIBCXX_BEGIN_NAMESPACE_CXX11 explicit basic_stringstream(__string_type&& __str, - ios_base::openmode __mode = ios_base::out + ios_base::openmode __mode = ios_base::in | ios_base::out) : __iostream_type(), _M_stringbuf(std::move(__str), __mode) { this->init(std::__addressof(_M_stringbuf)); } diff --git a/libstdc++-v3/testsuite/27_io/basic_stringstream/cons/char/97719.cc b/libstdc++-v3/testsuite/27_io/basic_stringstream/cons/char/97719.cc new file mode 100644 index 00000000000..fa523a803b6 --- /dev/null +++ b/libstdc++-v3/testsuite/27_io/basic_stringstream/cons/char/97719.cc @@ -0,0 +1,40 @@ +// Copyright (C) 2020 Free Software Foundation, Inc. +// +// This file is part of the GNU ISO C++ Library. This library is free +// software; you can redistribute it and/or modify it under the +// terms of the GNU General Public License as published by the +// Free Software Foundation; either version 3, or (at your option) +// any later version. + +// This library is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. + +// You should have received a copy of the GNU General Public License along +// with this library; see the file COPYING3. If not see +// . + +// { dg-options "-std=gnu++2a" } +// { dg-do run { target c++2a } } + +#include +#include +#include + +void +test01() +{ + // PR libstdc++/97719 + std::string str = "a"; + std::stringstream s(std::move(str)); + std::istreambuf_iterator i(s); + VERIFY( i != std::istreambuf_iterator() ); + VERIFY( *i == 'a' ); +} + +int +main() +{ + test01(); +}