public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Alan Modra <amodra@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r11-5802] Re: testsuite: Adjust target requirements for sad-vectorize and signbit
Date: Sun,  6 Dec 2020 05:24:58 +0000 (GMT)	[thread overview]
Message-ID: <20201206052458.B8F81385703F@sourceware.org> (raw)

https://gcc.gnu.org/g:1fab57f26ec24ce4e5672a7515c88611eba2483f

commit r11-5802-g1fab57f26ec24ce4e5672a7515c88611eba2483f
Author: Alan Modra <amodra@gmail.com>
Date:   Thu Oct 29 17:17:47 2020 +1030

    Re: testsuite: Adjust target requirements for sad-vectorize and signbit
    
    Fixes
    FAIL: gcc.target/powerpc/signbit-1.c scan-assembler-not stxvd2x
    FAIL: gcc.target/powerpc/signbit-1.c scan-assembler-times mfvsrd 3
    FAIL: gcc.target/powerpc/signbit-1.c scan-assembler-times srdi 3
    FAIL: gcc.target/powerpc/signbit-2.c scan-assembler-times ld 1
    FAIL: gcc.target/powerpc/signbit-2.c scan-assembler-times srdi 1
    on powerpc-linux (or powerpc64-linux biarch -m32).
    
    signbit-1.c is quite obviously a 64-bit only testcase given the
    scan-assembler directives, and the purpose of the testcase to verify
    the 64-bit only UNSPEC_SIGNBIT patterns.  It could be made to pass for
    -m32 by adding -mpowerpc64, but that option that isn't very effective
    when bi-arch testing and results in errors on rs6000-aix.  And it is
    pointless to match -m32 stores to the stack followed by loads, which
    is what we do at the moment.
    
    signbit-2.c on the other hand has more reasonable 32-bit output.
    
            * gcc.target/powerpc/signbit-1.c: Reinstate lp64 condition.
            * gcc.target/powerpc/signbit-2.c: Match 32-bit output too.

Diff:
---
 gcc/testsuite/gcc.target/powerpc/signbit-1.c | 1 +
 gcc/testsuite/gcc.target/powerpc/signbit-2.c | 6 ++++--
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/gcc/testsuite/gcc.target/powerpc/signbit-1.c b/gcc/testsuite/gcc.target/powerpc/signbit-1.c
index eb4f53e397d..1642bf46d7a 100644
--- a/gcc/testsuite/gcc.target/powerpc/signbit-1.c
+++ b/gcc/testsuite/gcc.target/powerpc/signbit-1.c
@@ -1,4 +1,5 @@
 /* { dg-do compile } */
+/* { dg-require-effective-target lp64 } */
 /* { dg-require-effective-target ppc_float128_sw } */
 /* { dg-require-effective-target powerpc_p8vector_ok } */
 /* { dg-options "-mdejagnu-cpu=power8 -O2 -mfloat128" } */
diff --git a/gcc/testsuite/gcc.target/powerpc/signbit-2.c b/gcc/testsuite/gcc.target/powerpc/signbit-2.c
index ff6af963dda..1b792916eba 100644
--- a/gcc/testsuite/gcc.target/powerpc/signbit-2.c
+++ b/gcc/testsuite/gcc.target/powerpc/signbit-2.c
@@ -13,5 +13,7 @@ int do_signbit_kf (__float128 *a) { return __builtin_signbit (*a); }
 /* { dg-final { scan-assembler-not   "lxvw4x"   } } */
 /* { dg-final { scan-assembler-not   "lxsd"     } } */
 /* { dg-final { scan-assembler-not   "lxsdx"    } } */
-/* { dg-final { scan-assembler-times "ld"     1 } } */
-/* { dg-final { scan-assembler-times "srdi"   1 } } */
+/* { dg-final { scan-assembler-times "ld"     1 { target lp64 } } } */
+/* { dg-final { scan-assembler-times "srdi"   1 { target lp64 } } } */
+/* { dg-final { scan-assembler-times "lwz"    1 { target ilp32 } } } */
+/* { dg-final { scan-assembler-times "rlwinm" 1 { target ilp32 } } } */


                 reply	other threads:[~2020-12-06  5:24 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201206052458.B8F81385703F@sourceware.org \
    --to=amodra@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).