public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r11-5831] builtins: Avoid ICE with __builtin_clear_padding on POINTERS_EXTEND_UNSIGNED targets [PR98147]
@ 2020-12-07 18:21 Jakub Jelinek
0 siblings, 0 replies; only message in thread
From: Jakub Jelinek @ 2020-12-07 18:21 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:b737b70fad398728f6006e8397d1bb31ccea4ce7
commit r11-5831-gb737b70fad398728f6006e8397d1bb31ccea4ce7
Author: Jakub Jelinek <jakub@redhat.com>
Date: Mon Dec 7 19:20:25 2020 +0100
builtins: Avoid ICE with __builtin_clear_padding on POINTERS_EXTEND_UNSIGNED targets [PR98147]
The function that calls targetm.emit_call_builtin___clear_cache
asserts that each of the begin and end operands has either ptr_mode or
Pmode.
On most targets that is the same mode, but e.g. on aarch64 -mabi=ilp32
or a few others it is different. When a target has a clear cache
non-library handler, it will use create_address_operand which will do the
conversion to the right mode automatically, but when emitting a library
call, we just say the operands are ptr_mode even when they can be Pmode
too; in that case we need to convert explicitly.
2020-12-07 Jakub Jelinek <jakub@redhat.com>
PR target/98147
* builtins.c (default_emit_call_builtin___clear_cache): Call
convert_memory_address to ptr_mode on both begin and end.
* gcc.dg/pr98147.c: New test.
Diff:
---
gcc/builtins.c | 4 ++--
gcc/testsuite/gcc.dg/pr98147.c | 10 ++++++++++
2 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/gcc/builtins.c b/gcc/builtins.c
index bd12659712f..faa5030853b 100644
--- a/gcc/builtins.c
+++ b/gcc/builtins.c
@@ -7790,8 +7790,8 @@ default_emit_call_builtin___clear_cache (rtx begin, rtx end)
emit_library_call (callee,
LCT_NORMAL, VOIDmode,
- begin, ptr_mode,
- end, ptr_mode);
+ convert_memory_address (ptr_mode, begin), ptr_mode,
+ convert_memory_address (ptr_mode, end), ptr_mode);
}
/* Emit a call to __builtin___clear_cache, unless the target specifies
diff --git a/gcc/testsuite/gcc.dg/pr98147.c b/gcc/testsuite/gcc.dg/pr98147.c
new file mode 100644
index 00000000000..3edc7985f10
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr98147.c
@@ -0,0 +1,10 @@
+/* PR target/98147 */
+
+char buffer[32] = "foo bar";
+
+int
+main ()
+{
+ __builtin___clear_cache (buffer, buffer + 32);
+ return 0;
+}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-12-07 18:21 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-07 18:21 [gcc r11-5831] builtins: Avoid ICE with __builtin_clear_padding on POINTERS_EXTEND_UNSIGNED targets [PR98147] Jakub Jelinek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).