From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2153) id 1018838618B2; Mon, 7 Dec 2020 18:21:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1018838618B2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Jakub Jelinek To: gcc-cvs@gcc.gnu.org Subject: [gcc r11-5831] builtins: Avoid ICE with __builtin_clear_padding on POINTERS_EXTEND_UNSIGNED targets [PR98147] X-Act-Checkin: gcc X-Git-Author: Jakub Jelinek X-Git-Refname: refs/heads/master X-Git-Oldrev: c3a1b3e6fb24ccf6f45e7d6ce904d5549bba01d6 X-Git-Newrev: b737b70fad398728f6006e8397d1bb31ccea4ce7 Message-Id: <20201207182106.1018838618B2@sourceware.org> Date: Mon, 7 Dec 2020 18:21:06 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Dec 2020 18:21:06 -0000 https://gcc.gnu.org/g:b737b70fad398728f6006e8397d1bb31ccea4ce7 commit r11-5831-gb737b70fad398728f6006e8397d1bb31ccea4ce7 Author: Jakub Jelinek Date: Mon Dec 7 19:20:25 2020 +0100 builtins: Avoid ICE with __builtin_clear_padding on POINTERS_EXTEND_UNSIGNED targets [PR98147] The function that calls targetm.emit_call_builtin___clear_cache asserts that each of the begin and end operands has either ptr_mode or Pmode. On most targets that is the same mode, but e.g. on aarch64 -mabi=ilp32 or a few others it is different. When a target has a clear cache non-library handler, it will use create_address_operand which will do the conversion to the right mode automatically, but when emitting a library call, we just say the operands are ptr_mode even when they can be Pmode too; in that case we need to convert explicitly. 2020-12-07 Jakub Jelinek PR target/98147 * builtins.c (default_emit_call_builtin___clear_cache): Call convert_memory_address to ptr_mode on both begin and end. * gcc.dg/pr98147.c: New test. Diff: --- gcc/builtins.c | 4 ++-- gcc/testsuite/gcc.dg/pr98147.c | 10 ++++++++++ 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/gcc/builtins.c b/gcc/builtins.c index bd12659712f..faa5030853b 100644 --- a/gcc/builtins.c +++ b/gcc/builtins.c @@ -7790,8 +7790,8 @@ default_emit_call_builtin___clear_cache (rtx begin, rtx end) emit_library_call (callee, LCT_NORMAL, VOIDmode, - begin, ptr_mode, - end, ptr_mode); + convert_memory_address (ptr_mode, begin), ptr_mode, + convert_memory_address (ptr_mode, end), ptr_mode); } /* Emit a call to __builtin___clear_cache, unless the target specifies diff --git a/gcc/testsuite/gcc.dg/pr98147.c b/gcc/testsuite/gcc.dg/pr98147.c new file mode 100644 index 00000000000..3edc7985f10 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr98147.c @@ -0,0 +1,10 @@ +/* PR target/98147 */ + +char buffer[32] = "foo bar"; + +int +main () +{ + __builtin___clear_cache (buffer, buffer + 32); + return 0; +}