public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r11-5859] libgcc: block signals when releasing split-stack memory
@ 2020-12-08 18:18 Ian Lance Taylor
0 siblings, 0 replies; only message in thread
From: Ian Lance Taylor @ 2020-12-08 18:18 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:f41dd93ade24f22f8cd1863129ab20c821000134
commit r11-5859-gf41dd93ade24f22f8cd1863129ab20c821000134
Author: Ian Lance Taylor <iant@golang.org>
Date: Tue Dec 8 10:17:16 2020 -0800
libgcc: block signals when releasing split-stack memory
* generic-morestack-thread.c (free_segments): Block signals during
thread exit.
Diff:
---
libgcc/generic-morestack-thread.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/libgcc/generic-morestack-thread.c b/libgcc/generic-morestack-thread.c
index 83a65501272..fd391bb2e1f 100644
--- a/libgcc/generic-morestack-thread.c
+++ b/libgcc/generic-morestack-thread.c
@@ -38,6 +38,7 @@ see the files COPYING3 and COPYING.RUNTIME respectively. If not, see
#ifndef inhibit_libc
#include <errno.h>
+#include <signal.h>
#include <pthread.h>
#include "generic-morestack.h"
@@ -54,6 +55,9 @@ extern int pthread_key_create (pthread_key_t *, void (*) (void *))
extern int pthread_setspecific (pthread_key_t, const void *)
__attribute__ ((weak));
+extern int pthread_sigmask (int, const sigset_t *, sigset_t *)
+ __attribute__ ((weak));
+
/* The key for the list of stack segments to free when the thread
exits. This is created by pthread_key_create. */
@@ -70,6 +74,16 @@ static pthread_once_t create_key_once = PTHREAD_ONCE_INIT;
static void
free_segments (void* arg)
{
+ /* We must block signals in case the signal handler tries to split
+ the stack. We leave them blocked while the thread exits. */
+ if (pthread_sigmask)
+ {
+ sigset_t mask;
+
+ sigfillset (&mask);
+ pthread_sigmask (SIG_BLOCK, &mask, NULL);
+ }
+
__morestack_release_segments ((struct stack_segment **) arg, 1);
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-12-08 18:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-08 18:18 [gcc r11-5859] libgcc: block signals when releasing split-stack memory Ian Lance Taylor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).