public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Martin Liska <marxin@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc(refs/users/marxin/heads/PR97868-tsan-fences)] Add -Wtsan. Date: Fri, 11 Dec 2020 10:04:25 +0000 (GMT) [thread overview] Message-ID: <20201211100425.7E649384400F@sourceware.org> (raw) https://gcc.gnu.org/g:7c982d06749fd3650825a5fb417e5e3487ecbcaf commit 7c982d06749fd3650825a5fb417e5e3487ecbcaf Author: Martin Liska <mliska@suse.cz> Date: Mon Dec 7 15:55:59 2020 +0100 Add -Wtsan. gcc/ChangeLog: PR sanitizer/97868 * common.opt: Add new warning -Wtsan. * doc/invoke.texi: Likewise. * tsan.c (instrument_builtin_call): Warn users about unsupported std::atomic_thread_fence. gcc/testsuite/ChangeLog: PR sanitizer/97868 * gcc.dg/tsan/atomic-fence.c: New test. Diff: --- gcc/common.opt | 4 ++++ gcc/doc/invoke.texi | 8 +++++++- gcc/testsuite/gcc.dg/tsan/atomic-fence.c | 11 +++++++++++ gcc/tsan.c | 6 ++++++ 4 files changed, 28 insertions(+), 1 deletion(-) diff --git a/gcc/common.opt b/gcc/common.opt index 6645539f5e5..4ab5fe44737 100644 --- a/gcc/common.opt +++ b/gcc/common.opt @@ -842,6 +842,10 @@ Wvector-operation-performance Common Var(warn_vector_operation_performance) Warning Warn when a vector operation is compiled outside the SIMD. +Wtsan +Common Var(warn_tsan) Init(1) Warning +Warn about unsupported features in ThreadSanitizer. + Xassembler Driver Separate diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi index 8b871e8bffd..abd2d3145fc 100644 --- a/gcc/doc/invoke.texi +++ b/gcc/doc/invoke.texi @@ -377,7 +377,7 @@ Objective-C and Objective-C++ Dialects}. -Wswitch -Wno-switch-bool -Wswitch-default -Wswitch-enum @gol -Wno-switch-outside-range -Wno-switch-unreachable -Wsync-nand @gol -Wsystem-headers -Wtautological-compare -Wtrampolines -Wtrigraphs @gol --Wtype-limits -Wundef @gol +-Wtsan -Wtype-limits -Wundef @gol -Wuninitialized -Wunknown-pragmas @gol -Wunsuffixed-float-constants -Wunused @gol -Wunused-but-set-parameter -Wunused-but-set-variable @gol @@ -7951,6 +7951,12 @@ Note that the code above is invalid in C++11. This warning is enabled by default. +@item -Wtsan +@opindex Wtsan +@opindex Wno-tsan +Warn about unsupported features in ThreadSanitizer. +This warning is enabled by default. + @item -Wtype-limits @opindex Wtype-limits @opindex Wno-type-limits diff --git a/gcc/testsuite/gcc.dg/tsan/atomic-fence.c b/gcc/testsuite/gcc.dg/tsan/atomic-fence.c new file mode 100644 index 00000000000..013720c2969 --- /dev/null +++ b/gcc/testsuite/gcc.dg/tsan/atomic-fence.c @@ -0,0 +1,11 @@ +/* PR sanitizer/97868 */ +/* { dg-do compile } */ +/* { dg-options "-fsanitize=thread" } */ + +int +main () +{ + __atomic_thread_fence (__ATOMIC_RELAXED); /* { dg-warning ".atomic_thread_fence. is not supported with .-fsanitize=thread." } */ + return 0; +} + diff --git a/gcc/tsan.c b/gcc/tsan.c index 4d6223454b5..1bc020e7648 100644 --- a/gcc/tsan.c +++ b/gcc/tsan.c @@ -45,6 +45,7 @@ along with GCC; see the file COPYING3. If not see #include "asan.h" #include "builtins.h" #include "target.h" +#include "diagnostic-core.h" /* Number of instrumented memory accesses in the current function. */ @@ -500,6 +501,11 @@ instrument_builtin_call (gimple_stmt_iterator *gsi) continue; else { + if (fcode == BUILT_IN_ATOMIC_THREAD_FENCE) + warning_at (gimple_location (stmt), OPT_Wtsan, + "%qs is not supported with %qs", "atomic_thread_fence", + "-fsanitize=thread"); + tree decl = builtin_decl_implicit (tsan_atomic_table[i].tsan_fcode); if (decl == NULL_TREE) return;
next reply other threads:[~2020-12-11 10:04 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-11 10:04 Martin Liska [this message] -- strict thread matches above, loose matches on Subject: below -- 2020-12-09 9:23 Martin Liska 2020-12-07 14:56 Martin Liska
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201211100425.7E649384400F@sourceware.org \ --to=marxin@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).