From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1914) id 47503389246A; Mon, 14 Dec 2020 15:53:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 47503389246A MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Pierre-Marie de Rodat To: gcc-cvs@gcc.gnu.org Subject: [gcc r11-6000] [Ada] Avoid reanalysis of malformed dependency relations X-Act-Checkin: gcc X-Git-Author: Piotr Trojanek X-Git-Refname: refs/heads/master X-Git-Oldrev: d494f9f037b7c24aeeaee5cd2e84fc9863728086 X-Git-Newrev: 2a1a3fc67f4ce399992ff83d97f76c2682dcb38f Message-Id: <20201214155312.47503389246A@sourceware.org> Date: Mon, 14 Dec 2020 15:53:12 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Dec 2020 15:53:12 -0000 https://gcc.gnu.org/g:2a1a3fc67f4ce399992ff83d97f76c2682dcb38f commit r11-6000-g2a1a3fc67f4ce399992ff83d97f76c2682dcb38f Author: Piotr Trojanek Date: Mon Nov 16 21:40:56 2020 +0100 [Ada] Avoid reanalysis of malformed dependency relations gcc/ada/ * sem_prag.adb (Analyze_Depends_In_Decl_Part): Replace early returns with goto Leave. (Collect_Subprogram_Inputs_Outputs): Fix style in comment. Diff: --- gcc/ada/sem_prag.adb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gcc/ada/sem_prag.adb b/gcc/ada/sem_prag.adb index 0a8e99bd10d..fe22510baf5 100644 --- a/gcc/ada/sem_prag.adb +++ b/gcc/ada/sem_prag.adb @@ -1975,7 +1975,7 @@ package body Sem_Prag is -- clause as this will lead to misleading errors. if Has_Extra_Parentheses (Deps) then - return; + goto Leave; end if; if Present (Component_Associations (Deps)) then @@ -2066,7 +2066,7 @@ package body Sem_Prag is else Error_Msg_N ("malformed dependency relation", Deps); - return; + goto Leave; end if; -- The top level dependency relation is malformed. This is a syntax @@ -30226,7 +30226,7 @@ package body Sem_Prag is Global := Get_Pragma (Subp_Id, Pragma_Refined_Global); -- Subprogram declaration or stand-alone body case, look for pragmas - -- Depends and Global + -- Depends and Global. else Depends := Get_Pragma (Spec_Id, Pragma_Depends);