public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Nathan Sidwell <nathan@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r11-6224] libcody: Remove nop asm
Date: Thu, 17 Dec 2020 13:36:59 +0000 (GMT)	[thread overview]
Message-ID: <20201217133659.A37173846079@sourceware.org> (raw)

https://gcc.gnu.org/g:5357b1620c547a6f2bd81e7868c800e2eee97e51

commit r11-6224-g5357b1620c547a6f2bd81e7868c800e2eee97e51
Author: Nathan Sidwell <nathan@acm.org>
Date:   Thu Dec 17 05:31:42 2020 -0800

    libcody: Remove nop asm
    
    This asm was a useful place for gdb to drop a breakpoint and make it
    clear where you were when debugging.  I took a punt that 'surely every
    arch has a nop instruction'. Well, no, some apparently have nops with
    operands (what, do nothing harder? :)
    
            libcody/
            * fatal.cc (HCF): Remove nop breakpoint lander.

Diff:
---
 libcody/fatal.cc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/libcody/fatal.cc b/libcody/fatal.cc
index b35094e6b19..c1bc8ab8a79 100644
--- a/libcody/fatal.cc
+++ b/libcody/fatal.cc
@@ -30,7 +30,8 @@ void (HCF) (char const *msg
 #endif
 	  ) noexcept
 { // HCF - you goofed!
-  __asm__ volatile ("nop");  // HCF - you goofed!
+  // A useful place for a breakpoint to land.
+  //__asm__ volatile ("nop");  // HCF - you goofed!
 
 #if !NMS_CHECKING
   constexpr Location loc (nullptr, 0);


                 reply	other threads:[~2020-12-17 13:36 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201217133659.A37173846079@sourceware.org \
    --to=nathan@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).