public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r11-6224] libcody: Remove nop asm
@ 2020-12-17 13:36 Nathan Sidwell
0 siblings, 0 replies; only message in thread
From: Nathan Sidwell @ 2020-12-17 13:36 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:5357b1620c547a6f2bd81e7868c800e2eee97e51
commit r11-6224-g5357b1620c547a6f2bd81e7868c800e2eee97e51
Author: Nathan Sidwell <nathan@acm.org>
Date: Thu Dec 17 05:31:42 2020 -0800
libcody: Remove nop asm
This asm was a useful place for gdb to drop a breakpoint and make it
clear where you were when debugging. I took a punt that 'surely every
arch has a nop instruction'. Well, no, some apparently have nops with
operands (what, do nothing harder? :)
libcody/
* fatal.cc (HCF): Remove nop breakpoint lander.
Diff:
---
libcody/fatal.cc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libcody/fatal.cc b/libcody/fatal.cc
index b35094e6b19..c1bc8ab8a79 100644
--- a/libcody/fatal.cc
+++ b/libcody/fatal.cc
@@ -30,7 +30,8 @@ void (HCF) (char const *msg
#endif
) noexcept
{ // HCF - you goofed!
- __asm__ volatile ("nop"); // HCF - you goofed!
+ // A useful place for a breakpoint to land.
+ //__asm__ volatile ("nop"); // HCF - you goofed!
#if !NMS_CHECKING
constexpr Location loc (nullptr, 0);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-12-17 13:36 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-17 13:36 [gcc r11-6224] libcody: Remove nop asm Nathan Sidwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).