public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r11-6286] libcody: to_string is not always available [PR 98412]
@ 2020-12-21 13:42 Nathan Sidwell
  0 siblings, 0 replies; only message in thread
From: Nathan Sidwell @ 2020-12-21 13:42 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:119d7478d1a7d59a0fa5a02690b2555ac2c3ed89

commit r11-6286-g119d7478d1a7d59a0fa5a02690b2555ac2c3ed89
Author: Nathan Sidwell <nathan@acm.org>
Date:   Mon Dec 21 05:38:34 2020 -0800

    libcody: to_string is not always available [PR 98412]
    
    to_string is not always available, so don't use it.
    
            libcody/
            * buffer.cc (MessageBuffer::AppendInteger): Workaround
            to_string's non-ubiquity.

Diff:
---
 libcody/buffer.cc | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/libcody/buffer.cc b/libcody/buffer.cc
index 3256c37399b..85c066fef71 100644
--- a/libcody/buffer.cc
+++ b/libcody/buffer.cc
@@ -146,7 +146,13 @@ void MessageBuffer::Append (char c)
 
 void MessageBuffer::AppendInteger (unsigned u)
 {
-  std::string v (std::to_string (u));
+  // Sigh, even though std::to_string is C++11, we support building on
+  // gcc 4.8, which is a C++11 compiler lacking std::to_string.  so
+  // have something horrible.
+  std::string v (20, 0);
+  size_t len = snprintf (const_cast<char *> (v.data ()), v.size (), "%u", u);
+  v.erase (len);
+
   AppendWord (v);
 }


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-12-21 13:42 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-21 13:42 [gcc r11-6286] libcody: to_string is not always available [PR 98412] Nathan Sidwell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).