public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Alexandre Oliva <aoliva@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc(refs/users/aoliva/heads/testme)] declare getpass in analyzer/sensitive-1.c test
Date: Fri,  1 Jan 2021 01:30:37 +0000 (GMT)	[thread overview]
Message-ID: <20210101013037.3729D3857815@sourceware.org> (raw)

https://gcc.gnu.org/g:a157d8c865f63d7b67b9dcc9a7ca72f06cc6ade1

commit a157d8c865f63d7b67b9dcc9a7ca72f06cc6ade1
Author: Alexandre Oliva <oliva@adacore.com>
Date:   Thu Dec 31 21:38:17 2020 -0300

    declare getpass in analyzer/sensitive-1.c test
    
    The getpass function is not available on all systems; and not
    necessarily declared in unistd.h, as expected by the sensitive-1
    analyzer test.
    
    Since this is a compile-only test, it doesn't really matter if the
    function is defined in the system libraries.  All we need is a
    declaration, to avoid warnings from calling an undeclared function.
    This patch adds the declaration, in a way that is most unlikely to
    conflict with any existing declaration.
    
    
    for  gcc/testsuite/ChangeLog
    
            * gcc.dg/analyzer/sensitive-1.c: Declare getpass.

Diff:
---
 gcc/testsuite/gcc.dg/analyzer/sensitive-1.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/gcc/testsuite/gcc.dg/analyzer/sensitive-1.c b/gcc/testsuite/gcc.dg/analyzer/sensitive-1.c
index 81144af620e..c66af927617 100644
--- a/gcc/testsuite/gcc.dg/analyzer/sensitive-1.c
+++ b/gcc/testsuite/gcc.dg/analyzer/sensitive-1.c
@@ -6,6 +6,11 @@
 
 #include <string.h>
 
+/* Declare getpass, in case unistd doesn't declare it.
+   Parenthesize it, in case it's a macro.
+   Don't use a prototype, to avoid const mismatches.  */
+extern char *(getpass) ();
+
 char test_1 (FILE *logfile)
 {
   char *password = getpass (">"); /* { dg-message "\\(1\\) sensitive value acquired here" } */


             reply	other threads:[~2021-01-01  1:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-01  1:30 Alexandre Oliva [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-01-01  5:22 Alexandre Oliva
2020-12-25  1:47 Alexandre Oliva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210101013037.3729D3857815@sourceware.org \
    --to=aoliva@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).