From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2153) id 82E21388A837; Tue, 20 Apr 2021 23:33:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 82E21388A837 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Jakub Jelinek To: gcc-cvs@gcc.gnu.org Subject: [gcc r9-9437] c++: Diagnose bare parameter packs in bitfield widths [PR99745] X-Act-Checkin: gcc X-Git-Author: Jakub Jelinek X-Git-Refname: refs/heads/releases/gcc-9 X-Git-Oldrev: dd320787b4eb11521e3ae3f9aa9504b31ee08c36 X-Git-Newrev: 4b30a6d214ad94dfdffa93843d628484d2555b51 Message-Id: <20210420233355.82E21388A837@sourceware.org> Date: Tue, 20 Apr 2021 23:33:55 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Apr 2021 23:33:55 -0000 https://gcc.gnu.org/g:4b30a6d214ad94dfdffa93843d628484d2555b51 commit r9-9437-g4b30a6d214ad94dfdffa93843d628484d2555b51 Author: Jakub Jelinek Date: Thu Mar 25 21:06:09 2021 +0100 c++: Diagnose bare parameter packs in bitfield widths [PR99745] The following invalid tests ICE because we don't diagnose (and drop) bare parameter packs in bitfield widths. 2021-03-25 Jakub Jelinek PR c++/99745 * decl2.c (grokbitfield): Diagnose bitfields containing bare parameter packs and don't set DECL_BIT_FIELD_REPRESENTATIVE in that case. * g++.dg/cpp0x/variadic181.C: New test. (cherry picked from commit f8780caf07340f5d5e55cf5fb1b2be07cabab1ea) Diff: --- gcc/cp/decl2.c | 2 +- gcc/testsuite/g++.dg/cpp0x/variadic181.C | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/gcc/cp/decl2.c b/gcc/cp/decl2.c index a15bb3c45cc..672bd62f1ce 100644 --- a/gcc/cp/decl2.c +++ b/gcc/cp/decl2.c @@ -1098,7 +1098,7 @@ grokbitfield (const cp_declarator *declarator, && !INTEGRAL_OR_UNSCOPED_ENUMERATION_TYPE_P (TREE_TYPE (width))) error ("width of bit-field %qD has non-integral type %qT", value, TREE_TYPE (width)); - else + else if (!check_for_bare_parameter_packs (width)) { /* Temporarily stash the width in DECL_BIT_FIELD_REPRESENTATIVE. check_bitfield_decl picks it from there later and sets DECL_SIZE diff --git a/gcc/testsuite/g++.dg/cpp0x/variadic181.C b/gcc/testsuite/g++.dg/cpp0x/variadic181.C new file mode 100644 index 00000000000..0bb6fe7a8f3 --- /dev/null +++ b/gcc/testsuite/g++.dg/cpp0x/variadic181.C @@ -0,0 +1,9 @@ +// PR c++/99745 +// { dg-do compile { target c++11 } } + +template +struct S { int a : sizeof(Ts); }; // { dg-error "parameter packs not expanded with '\.\.\.':" } +S s; // { dg-message "'Ts'" "" { target *-*-* } .-1 } +template +struct T { int a : Ns; }; // { dg-error "parameter packs not expanded with '\.\.\.':" } +T<0> t; // { dg-message "'Ns'" "" { target *-*-* } .-1 }