public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Thomas Rodgers <rodgertq@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org Subject: [gcc r11-8277] [libstdc++] Fix test timeout in stop_calback/destroy.cc Date: Thu, 22 Apr 2021 01:32:43 +0000 (GMT) [thread overview] Message-ID: <20210422013243.4E44A3846079@sourceware.org> (raw) https://gcc.gnu.org/g:c0ffafb343ac80654e87b459492c575b7916d60c commit r11-8277-gc0ffafb343ac80654e87b459492c575b7916d60c Author: Thomas Rodgers <rodgert@twrodgers.com> Date: Wed Apr 21 10:01:06 2021 -0700 [libstdc++] Fix test timeout in stop_calback/destroy.cc A change was made to __atomic_semaphore::_S_do_try_acquire() to (ideally) let the compare_exchange reload the value of __old rather than always reloading it twice. This causes _M_acquire to spin indefinitely if the value of __old is already 0. libstdc++-v3/ChangeLog: * include/bits/semaphore_base.h: Always reload __old in __atomic_semaphore::_S_do_try_acquire(). * testsuite/30_threads/stop_token/stop_callback/destroy.cc: re-enable testcase. (cherry picked from commit 7eeb8c04e53fa880ee559efb727517ce778d17a0) Diff: --- libstdc++-v3/include/bits/semaphore_base.h | 16 ++++++---------- .../30_threads/stop_token/stop_callback/destroy.cc | 2 -- 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/libstdc++-v3/include/bits/semaphore_base.h b/libstdc++-v3/include/bits/semaphore_base.h index 35469e443b0..84b33423fff 100644 --- a/libstdc++-v3/include/bits/semaphore_base.h +++ b/libstdc++-v3/include/bits/semaphore_base.h @@ -196,9 +196,9 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION __atomic_semaphore& operator=(const __atomic_semaphore&) = delete; static _GLIBCXX_ALWAYS_INLINE bool - _S_do_try_acquire(__detail::__platform_wait_t* __counter, - __detail::__platform_wait_t& __old) noexcept + _S_do_try_acquire(__detail::__platform_wait_t* __counter) noexcept { + auto __old = __atomic_impl::load(__counter, memory_order::acquire); if (__old == 0) return false; @@ -211,18 +211,16 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION _GLIBCXX_ALWAYS_INLINE void _M_acquire() noexcept { - auto __old = __atomic_impl::load(&_M_counter, memory_order::acquire); auto const __pred = - [this, &__old] { return _S_do_try_acquire(&this->_M_counter, __old); }; + [this] { return _S_do_try_acquire(&this->_M_counter); }; std::__atomic_wait_address_bare(&_M_counter, __pred); } bool _M_try_acquire() noexcept { - auto __old = __atomic_impl::load(&_M_counter, memory_order::acquire); auto const __pred = - [this, &__old] { return _S_do_try_acquire(&this->_M_counter, __old); }; + [this] { return _S_do_try_acquire(&this->_M_counter); }; return std::__detail::__atomic_spin(__pred); } @@ -231,9 +229,8 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION _M_try_acquire_until(const chrono::time_point<_Clock, _Duration>& __atime) noexcept { - auto __old = __atomic_impl::load(&_M_counter, memory_order_relaxed); auto const __pred = - [this, &__old] { return _S_do_try_acquire(&this->_M_counter, __old); }; + [this] { return _S_do_try_acquire(&this->_M_counter); }; return __atomic_wait_address_until_bare(&_M_counter, __pred, __atime); } @@ -243,9 +240,8 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION _M_try_acquire_for(const chrono::duration<_Rep, _Period>& __rtime) noexcept { - auto __old = __atomic_impl::load(&_M_counter, memory_order_relaxed); auto const __pred = - [this, &__old] { return _S_do_try_acquire(&this->_M_counter, __old); }; + [this] { return _S_do_try_acquire(&this->_M_counter); }; return __atomic_wait_address_for_bare(&_M_counter, __pred, __rtime); } diff --git a/libstdc++-v3/testsuite/30_threads/stop_token/stop_callback/destroy.cc b/libstdc++-v3/testsuite/30_threads/stop_token/stop_callback/destroy.cc index c2cfba027cb..061ed448c33 100644 --- a/libstdc++-v3/testsuite/30_threads/stop_token/stop_callback/destroy.cc +++ b/libstdc++-v3/testsuite/30_threads/stop_token/stop_callback/destroy.cc @@ -21,8 +21,6 @@ // { dg-require-effective-target pthread } // { dg-require-gthreads "" } -// { dg-skip-if "FIXME: times out" { *-*-* } } - #include <stop_token> #include <atomic> #include <thread>
reply other threads:[~2021-04-22 1:32 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210422013243.4E44A3846079@sourceware.org \ --to=rodgertq@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ --cc=libstdc++-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).