public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Kwok Yeung <kcy@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc/devel/omp/gcc-11] openacc: Fix race condition in Fortran loop collapse tests
Date: Thu, 13 May 2021 16:15:27 +0000 (GMT)	[thread overview]
Message-ID: <20210513161527.8B33B3AA941E@sourceware.org> (raw)

https://gcc.gnu.org/g:70414a9d2bdd61829f83bc0037ce8c75a9d06964

commit 70414a9d2bdd61829f83bc0037ce8c75a9d06964
Author: Julian Brown <julian@codesourcery.com>
Date:   Thu Jun 25 07:40:53 2020 -0700

    openacc: Fix race condition in Fortran loop collapse tests
    
    The gangs participating in a gang-partitioned loop are not all guaranteed
    to complete before some given gang continues to execute beyond that loop.
    This means that two existing test cases contain a race condition,
    because a loop that may be gang-partitioned is followed immediately by
    another loop.  The fix is to place the loops in separate parallel regions.
    
    2020-07-15  Julian Brown  <julian@codesourcery.com>
    
    libgomp/
            * testsuite/libgomp.oacc-fortran/collapse-1.f90: Fix race condition.
            * testsuite/libgomp.oacc-fortran/collapse-2.f90: Likewise.

Diff:
---
 libgomp/ChangeLog.omp | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/libgomp/ChangeLog.omp b/libgomp/ChangeLog.omp
index e407b9f4399..48be697a23e 100644
--- a/libgomp/ChangeLog.omp
+++ b/libgomp/ChangeLog.omp
@@ -1,3 +1,8 @@
+2020-07-15  Julian Brown  <julian@codesourcery.com>
+
+	* testsuite/libgomp.oacc-fortran/collapse-1.f90: Fix race condition.
+	* testsuite/libgomp.oacc-fortran/collapse-2.f90: Likewise.
+
 2020-06-02  Kwok Cheung Yeung  <kcy@codesourcery.com>
 
 	* testsuite/libgomp.oacc-c-c++-common/routine-wv-2.c (DoWorkVec):


                 reply	other threads:[~2021-05-13 16:15 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210513161527.8B33B3AA941E@sourceware.org \
    --to=kcy@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).