public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc(refs/vendors/redhat/heads/gcc-8-branch)] aarch64: Fix ICE in aarch64_add_offset_1_temporaries [PR100302]
Date: Fri, 14 May 2021 14:56:52 +0000 (GMT)	[thread overview]
Message-ID: <20210514145652.DF6CC3943429@sourceware.org> (raw)

https://gcc.gnu.org/g:47316972d8f81363903b39fbe5313c5b013b09e7

commit 47316972d8f81363903b39fbe5313c5b013b09e7
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu Apr 29 11:34:50 2021 +0200

    aarch64: Fix ICE in aarch64_add_offset_1_temporaries [PR100302]
    
    In PR94121 I've changed aarch64_add_offset_1 to use absu_hwi instead of
    abs_hwi because offset can be HOST_WIDE_INT_MIN.  As can be seen with
    the testcase below, aarch64_add_offset_1_temporaries suffers from the same
    problem and should be in sync with aarch64_add_offset_1, i.e. for
    HOST_WIDE_INT_MIN it needs a temporary.
    
    2021-04-29  Jakub Jelinek  <jakub@redhat.com>
    
            PR target/100302
            * config/aarch64/aarch64.c (aarch64_add_offset_1_temporaries): Use
            absu_hwi instead of abs_hwi.
    
    (cherry picked from commit 1bb3e2c0ce6ed363c72caf814a6ba6d7b17c3e0a)

Diff:
---
 gcc/config/aarch64/aarch64.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c
index c1827beeaf7..4ad73220337 100644
--- a/gcc/config/aarch64/aarch64.c
+++ b/gcc/config/aarch64/aarch64.c
@@ -2566,7 +2566,7 @@ aarch64_mov128_immediate (rtx imm)
 static unsigned int
 aarch64_add_offset_1_temporaries (HOST_WIDE_INT offset)
 {
-  return abs_hwi (offset) < 0x1000000 ? 0 : 1;
+  return absu_hwi (offset) < 0x1000000 ? 0 : 1;
 }
 
 /* A subroutine of aarch64_add_offset.  Set DEST to SRC + OFFSET for


                 reply	other threads:[~2021-05-14 14:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210514145652.DF6CC3943429@sourceware.org \
    --to=jakub@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).