public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Christophe Lyon <clyon@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r12-816] testsuite/arm: Improve unsigned-float.c
Date: Sun, 16 May 2021 13:46:33 +0000 (GMT)	[thread overview]
Message-ID: <20210516134633.42C7E384A00F@sourceware.org> (raw)

https://gcc.gnu.org/g:f1146b50e8af87dc9da25cf6d8633e91dac07e1a

commit r12-816-gf1146b50e8af87dc9da25cf6d8633e91dac07e1a
Author: Christophe Lyon <christophe.lyon@linaro.org>
Date:   Sun May 16 13:46:06 2021 +0000

    testsuite/arm: Improve unsigned-float.c
    
    The test requires an FPU, so use -march=armv7-a+fp -mfpu=auto instead
    of -march=armv7-a.
    
    We also remove dg-require-effective-target arm_fp_ok, but keep
    dg-add-options arm_fp: this enables the test to pass on arm-eabi
    configured with default cpu/fpu/mode.
    
    dg-require-effective-target arm_fp_ok fails on such a configuration
    for lack of FPU, since dg-options are not taken into account by
    dg-require-effective-target.
    
    Add -march=armv7-a+fp -mfpu=auto is sufficient for arm_fp options to
    be acceptable.
    
    This enables the test to pass on all the arm-eabi configurations I'm
    testing, as well as arm-linux-gnueabi when forcing -march=armv5t.
    
    2021-05-16  Christophe Lyon  <christophe.lyon@linaro.org>
    
            gcc/testsuite/
            * gcc.target/arm/unsigned-float.c: Remove arm_fp_ok, adjust
            dg-options.

Diff:
---
 gcc/testsuite/gcc.target/arm/unsigned-float.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gcc/testsuite/gcc.target/arm/unsigned-float.c b/gcc/testsuite/gcc.target/arm/unsigned-float.c
index ad589d9eba4..ea3abc76fd6 100644
--- a/gcc/testsuite/gcc.target/arm/unsigned-float.c
+++ b/gcc/testsuite/gcc.target/arm/unsigned-float.c
@@ -1,8 +1,8 @@
 /* { dg-do compile } */
-/* { dg-require-effective-target arm_fp_ok } */
-/* { dg-skip-if "need fp instructions" { *-*-* } { "-mfloat-abi=soft" } { "" } } */
 /* { dg-skip-if "-mpure-code supports M-profile only" { *-*-* } { "-mpure-code" } } */
-/* { dg-options "-march=armv7-a -O1" } */
+/* { dg-options "-march=armv7-a+fp -mfpu=auto -O1" } */
+/* Do not require arm_ok effective target to avoid skipping on arm-eabi with
+   default configure options.  */
 /* { dg-add-options arm_fp } */


                 reply	other threads:[~2021-05-16 13:46 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210516134633.42C7E384A00F@sourceware.org \
    --to=clyon@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).