public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Andrew Macleod <amacleod@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r12-1047] fully populate the export list from range_cache, not gori_compute.
Date: Tue, 25 May 2021 23:29:34 +0000 (GMT)	[thread overview]
Message-ID: <20210525232934.4759B385803D@sourceware.org> (raw)

https://gcc.gnu.org/g:cb33af1a62b09576b0782ac36e5f5cff049f1035

commit r12-1047-gcb33af1a62b09576b0782ac36e5f5cff049f1035
Author: Andrew MacLeod <amacleod@redhat.com>
Date:   Tue May 25 13:53:25 2021 -0400

    fully populate the export list from range_cache, not gori_compute.
    
    Ranger wants to prepopulate all the export blocks so that it has an initial
    invariant set of names. GORI consumers shouldn't be penalized for ranger
    requirements.  This way any gori client remains lightweight.
    
            * gimple-range-cache.cc (ranger_cache::ranger_cache):  Move initial
            export cache filling to here.
            * gimple-range-gori.cc (gori_compute::gori_compute) : From Here.

Diff:
---
 gcc/gimple-range-cache.cc | 10 ++++++++++
 gcc/gimple-range-gori.cc  | 10 ----------
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/gcc/gimple-range-cache.cc b/gcc/gimple-range-cache.cc
index 2c922e32913..8ad76048272 100644
--- a/gcc/gimple-range-cache.cc
+++ b/gcc/gimple-range-cache.cc
@@ -618,6 +618,16 @@ ranger_cache::ranger_cache (gimple_ranger &q) : query (q)
   m_poor_value_list.safe_grow_cleared (20);
   m_poor_value_list.truncate (0);
   m_temporal = new temporal_cache;
+  unsigned x, lim = last_basic_block_for_fn (cfun);
+  // Calculate outgoing range info upfront.  This will fully populate the
+  // m_maybe_variant bitmap which will help eliminate processing of names
+  // which never have their ranges adjusted.
+  for (x = 0; x < lim ; x++)
+    {
+      basic_block bb = BASIC_BLOCK_FOR_FN (cfun, x);
+      if (bb)
+	exports (bb);
+    }
 }
 
 ranger_cache::~ranger_cache ()
diff --git a/gcc/gimple-range-gori.cc b/gcc/gimple-range-gori.cc
index 074c025be37..e30049edfbd 100644
--- a/gcc/gimple-range-gori.cc
+++ b/gcc/gimple-range-gori.cc
@@ -458,16 +458,6 @@ gori_compute::gori_compute ()
   // Create a boolean_type true and false range.
   m_bool_zero = int_range<2> (boolean_false_node, boolean_false_node);
   m_bool_one = int_range<2> (boolean_true_node, boolean_true_node);
-  unsigned x, lim = last_basic_block_for_fn (cfun);
-  // Calculate outgoing range info upfront.  This will fully populate the
-  // m_maybe_variant bitmap which will help eliminate processing of names
-  // which never have their ranges adjusted.
-  for (x = 0; x < lim ; x++)
-    {
-      basic_block bb = BASIC_BLOCK_FOR_FN (cfun, x);
-      if (bb)
-	exports (bb);
-    }
 }
 
 // Provide a default of VARYING for all incoming SSA names.


                 reply	other threads:[~2021-05-25 23:29 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210525232934.4759B385803D@sourceware.org \
    --to=amacleod@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).