From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mpolacek@sourceware.org>
Received: by sourceware.org (Postfix, from userid 1734)
 id 8A736385DC33; Tue,  8 Jun 2021 22:29:59 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8A736385DC33
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
From: Marek Polacek <mpolacek@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r12-1310] c++: explicit() ignored on deduction guide [PR100065]
X-Act-Checkin: gcc
X-Git-Author: Marek Polacek <polacek@redhat.com>
X-Git-Refname: refs/heads/master
X-Git-Oldrev: c4574d23cb07340918793a5a98ae7bb2988b3791
X-Git-Newrev: 1afa4facb9348cac0349ff9c30066aa25a3608f7
Message-Id: <20210608222959.8A736385DC33@sourceware.org>
Date: Tue,  8 Jun 2021 22:29:59 +0000 (GMT)
X-BeenThere: gcc-cvs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-cvs mailing list <gcc-cvs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-cvs>,
 <mailto:gcc-cvs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-cvs/>
List-Help: <mailto:gcc-cvs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-cvs>,
 <mailto:gcc-cvs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Jun 2021 22:29:59 -0000

https://gcc.gnu.org/g:1afa4facb9348cac0349ff9c30066aa25a3608f7

commit r12-1310-g1afa4facb9348cac0349ff9c30066aa25a3608f7
Author: Marek Polacek <polacek@redhat.com>
Date:   Mon Jun 7 16:06:00 2021 -0400

    c++: explicit() ignored on deduction guide [PR100065]
    
    When we have explicit() with a value-dependent argument, we can't
    evaluate it at parsing time, so cp_parser_function_specifier_opt stashes
    the argument into the decl-specifiers and grokdeclarator then stores it
    into explicit_specifier_map, which is then used when substituting the
    function decl.  grokdeclarator stores it for constructors and conversion
    functions, but we also need to do it for deduction guides, otherwise
    we'll forget that we've seen an explicit-specifier as in the attached
    test.
    
            PR c++/100065
    
    gcc/cp/ChangeLog:
    
            * decl.c (grokdeclarator): Store a value-dependent
            explicit-specifier even for deduction guides.
    
    gcc/testsuite/ChangeLog:
    
            * g++.dg/cpp2a/explicit18.C: New test.

Diff:
---
 gcc/cp/decl.c                           |  2 ++
 gcc/testsuite/g++.dg/cpp2a/explicit18.C | 23 +++++++++++++++++++++++
 2 files changed, 25 insertions(+)

diff --git a/gcc/cp/decl.c b/gcc/cp/decl.c
index a3687dbb0dd..cbf647dd569 100644
--- a/gcc/cp/decl.c
+++ b/gcc/cp/decl.c
@@ -14043,6 +14043,8 @@ grokdeclarator (const cp_declarator *declarator,
 		storage_class = sc_none;
 	      }
 	  }
+	if (declspecs->explicit_specifier)
+	  store_explicit_specifier (decl, declspecs->explicit_specifier);
       }
     else
       {
diff --git a/gcc/testsuite/g++.dg/cpp2a/explicit18.C b/gcc/testsuite/g++.dg/cpp2a/explicit18.C
new file mode 100644
index 00000000000..c8916fa4743
--- /dev/null
+++ b/gcc/testsuite/g++.dg/cpp2a/explicit18.C
@@ -0,0 +1,23 @@
+// PR c++/100065
+// { dg-do compile { target c++20 } }
+
+template<bool B>
+struct bool_constant {
+  static constexpr bool value = B;
+  constexpr operator bool() const { return value; }
+};
+
+using true_type = bool_constant<true>;
+using false_type = bool_constant<false>;
+
+template<bool>
+struct X {
+    template<typename T>
+    X(T);
+};
+
+template<bool b>
+explicit(b) X(bool_constant<b>) -> X<b>;
+
+X false_ = false_type{}; // OK
+X true_  = true_type{};  // { dg-error "explicit deduction guide" }