public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Iain Buclaw <ibuclaw@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r10-9899] d: TypeInfo error when using slice copy on Structs (PR100964)
Date: Wed,  9 Jun 2021 18:03:42 +0000 (GMT)	[thread overview]
Message-ID: <20210609180342.571F439A2433@sourceware.org> (raw)

https://gcc.gnu.org/g:d660f34b6718c5f107fd1f1a2126aec759a6593b

commit r10-9899-gd660f34b6718c5f107fd1f1a2126aec759a6593b
Author: Iain Buclaw <ibuclaw@gdcproject.org>
Date:   Wed Jun 9 19:39:28 2021 +0200

    d: TypeInfo error when using slice copy on Structs (PR100964)
    
    Known limitation: does not work for struct with postblit or dtor.
    
    gcc/d/ChangeLog:
    
            PR d/100964
            * dmd/expression.c (Expression::checkPostblit): Don't generate
            TypeInfo when RTTI is disabled.
    
    gcc/testsuite/ChangeLog:
    
            PR d/100964
            * gdc.test/compilable/betterCarray.d: Add test cases.
    
    (cherry picked from commit 10d4f283f4177d80cec3c9e8bf447a48cab5bb47)

Diff:
---
 gcc/d/dmd/expression.c                           |  7 +++++--
 gcc/testsuite/gdc.test/compilable/betterCarray.d | 10 ++++++++++
 2 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/gcc/d/dmd/expression.c b/gcc/d/dmd/expression.c
index c639fd10aae..92ec6ed328e 100644
--- a/gcc/d/dmd/expression.c
+++ b/gcc/d/dmd/expression.c
@@ -2655,8 +2655,11 @@ bool Expression::checkPostblit(Scope *sc, Type *t)
     t = t->baseElemOf();
     if (t->ty == Tstruct)
     {
-        // Bugzilla 11395: Require TypeInfo generation for array concatenation
-        semanticTypeInfo(sc, t);
+        if (global.params.useTypeInfo)
+        {
+            // Bugzilla 11395: Require TypeInfo generation for array concatenation
+            semanticTypeInfo(sc, t);
+        }
 
         StructDeclaration *sd = ((TypeStruct *)t)->sym;
         if (sd->postblit)
diff --git a/gcc/testsuite/gdc.test/compilable/betterCarray.d b/gcc/testsuite/gdc.test/compilable/betterCarray.d
index 74c80be3b95..3f48b042bde 100644
--- a/gcc/testsuite/gdc.test/compilable/betterCarray.d
+++ b/gcc/testsuite/gdc.test/compilable/betterCarray.d
@@ -15,3 +15,13 @@ int foo(int[] a, int i)
 {
     return a[i];
 }
+
+/**********************************************/
+// https://issues.dlang.org/show_bug.cgi?id=19234
+void issue19234()
+{
+    static struct A {}
+    A[10] a;
+    A[10] b;
+    b[] = a[];
+}


                 reply	other threads:[~2021-06-09 18:03 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210609180342.571F439A2433@sourceware.org \
    --to=ibuclaw@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).