From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1914) id DC6E93943412; Wed, 16 Jun 2021 08:44:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DC6E93943412 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Pierre-Marie de Rodat To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-1497] [Ada] Raise expressions and unconstrained components X-Act-Checkin: gcc X-Git-Author: Arnaud Charlet X-Git-Refname: refs/heads/master X-Git-Oldrev: a85d1c14073af24e79f19abf50271e219511054d X-Git-Newrev: 331170392082ccfb782a6edb263fc2a32d058c70 Message-Id: <20210616084406.DC6E93943412@sourceware.org> Date: Wed, 16 Jun 2021 08:44:06 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jun 2021 08:44:07 -0000 https://gcc.gnu.org/g:331170392082ccfb782a6edb263fc2a32d058c70 commit r12-1497-g331170392082ccfb782a6edb263fc2a32d058c70 Author: Arnaud Charlet Date: Wed Feb 17 06:29:03 2021 -0500 [Ada] Raise expressions and unconstrained components gcc/ada/ * sem_ch3.adb (Analyze_Component_Declaration): Do not special case raise expressions. gcc/testsuite/ * gnat.dg/limited4.adb: Disable illegal code. Diff: --- gcc/ada/sem_ch3.adb | 13 +------------ gcc/testsuite/gnat.dg/limited4.adb | 13 +++++++------ 2 files changed, 8 insertions(+), 18 deletions(-) diff --git a/gcc/ada/sem_ch3.adb b/gcc/ada/sem_ch3.adb index 03280e5244e..c6687b51c3b 100644 --- a/gcc/ada/sem_ch3.adb +++ b/gcc/ada/sem_ch3.adb @@ -2083,21 +2083,10 @@ package body Sem_Ch3 is end if; end if; - -- Avoid reporting spurious errors if the component is initialized with - -- a raise expression (which is legal in any expression context) - - if Present (E) - and then - (Nkind (E) = N_Raise_Expression - or else (Nkind (E) = N_Qualified_Expression - and then Nkind (Expression (E)) = N_Raise_Expression)) - then - null; - -- The parent type may be a private view with unknown discriminants, -- and thus unconstrained. Regular components must be constrained. - elsif not Is_Definite_Subtype (T) + if not Is_Definite_Subtype (T) and then Chars (Id) /= Name_uParent then if Is_Class_Wide_Type (T) then diff --git a/gcc/testsuite/gnat.dg/limited4.adb b/gcc/testsuite/gnat.dg/limited4.adb index 1a8ec97f91c..2a22a2c1b3f 100644 --- a/gcc/testsuite/gnat.dg/limited4.adb +++ b/gcc/testsuite/gnat.dg/limited4.adb @@ -22,11 +22,12 @@ procedure Limited4 is Obj2 : Lim_Tagged'Class := Lim_Tagged'Class'(raise TBD_Error); -- b) initialization expression of a CW component_declaration - - type Rec is record - Comp01 : Lim_Tagged'Class := (raise TBD_Error); - Comp02 : Lim_Tagged'Class := Lim_Tagged'Class'((raise TBD_Error)); - end record; + -- ... is illegal: cannot have unconstrained components. + -- + -- type Rec is record + -- Comp01 : Lim_Tagged'Class := (raise TBD_Error); + -- Comp02 : Lim_Tagged'Class := Lim_Tagged'Class'((raise TBD_Error)); + -- end record; -- c) the expression of a record_component_association @@ -55,4 +56,4 @@ procedure Limited4 is begin Check := Do_Test1 (raise TBD_Error); Check := Do_Test2; -end; \ No newline at end of file +end;