From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1914) id B1B7F398A877; Wed, 16 Jun 2021 08:44:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B1B7F398A877 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Pierre-Marie de Rodat To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-1504] [Ada] Do not perform useless work in Check_No_Parts_Violations X-Act-Checkin: gcc X-Git-Author: Eric Botcazou X-Git-Refname: refs/heads/master X-Git-Oldrev: 1ac6fcf57c55ec2cac914b64d5d56a341a5aa4f0 X-Git-Newrev: 5c44cc1c7363ed3e5ea506bb8c3479b5d2d67342 Message-Id: <20210616084442.B1B7F398A877@sourceware.org> Date: Wed, 16 Jun 2021 08:44:42 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jun 2021 08:44:42 -0000 https://gcc.gnu.org/g:5c44cc1c7363ed3e5ea506bb8c3479b5d2d67342 commit r12-1504-g5c44cc1c7363ed3e5ea506bb8c3479b5d2d67342 Author: Eric Botcazou Date: Tue Feb 23 12:50:25 2021 +0100 [Ada] Do not perform useless work in Check_No_Parts_Violations gcc/ada/ * freeze.adb (Check_No_Parts_Violations): Return earlier if the type is elementary or does not come from source. Diff: --- gcc/ada/freeze.adb | 35 +++++++++++++++++++---------------- 1 file changed, 19 insertions(+), 16 deletions(-) diff --git a/gcc/ada/freeze.adb b/gcc/ada/freeze.adb index 91f17244dae..fd8216969a7 100644 --- a/gcc/ada/freeze.adb +++ b/gcc/ada/freeze.adb @@ -2584,27 +2584,30 @@ package body Freeze is -- Local declarations - Types_With_Aspect : Elist_Id := - Get_Types_With_Aspect_In_Hierarchy (Typ); - - Aspect_Value : Entity_Id; - Curr_Value : Entity_Id; - Curr_Typ_Elmt : Elmt_Id; - Curr_Body_Elmt : Elmt_Id; - Curr_Formal_Elmt : Elmt_Id; - Gen_Bodies : Elist_Id; - Gen_Formals : Elist_Id; - Scop : Entity_Id; + Aspect_Value : Entity_Id; + Curr_Value : Entity_Id; + Curr_Typ_Elmt : Elmt_Id; + Curr_Body_Elmt : Elmt_Id; + Curr_Formal_Elmt : Elmt_Id; + Gen_Bodies : Elist_Id; + Gen_Formals : Elist_Id; + Scop : Entity_Id; + Types_With_Aspect : Elist_Id; -- Start of processing for Check_No_Parts_Violations begin - -- There are no types with No_Parts specified, so there - -- is nothing to check. + -- Nothing to check if the type is elementary or artificial - if Is_Empty_Elmt_List (Types_With_Aspect) - or else not Comes_From_Source (Typ) - then + if Is_Elementary_Type (Typ) or else not Comes_From_Source (Typ) then + return; + end if; + + Types_With_Aspect := Get_Types_With_Aspect_In_Hierarchy (Typ); + + -- Nothing to check if there are no types with No_Parts specified + + if Is_Empty_Elmt_List (Types_With_Aspect) then return; end if;