From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2153) id 75AAB383B414; Wed, 16 Jun 2021 11:15:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 75AAB383B414 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Jakub Jelinek To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-1528] testsuite: Use noipa attribute instead of noinline, noclone X-Act-Checkin: gcc X-Git-Author: Jakub Jelinek X-Git-Refname: refs/heads/master X-Git-Oldrev: b4b50bf2864e09f028a39a3f460222632c4d7348 X-Git-Newrev: a490b1dc0b3c26bff2ee00ac0da2d606d2009e3a Message-Id: <20210616111541.75AAB383B414@sourceware.org> Date: Wed, 16 Jun 2021 11:15:41 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jun 2021 11:15:41 -0000 https://gcc.gnu.org/g:a490b1dc0b3c26bff2ee00ac0da2d606d2009e3a commit r12-1528-ga490b1dc0b3c26bff2ee00ac0da2d606d2009e3a Author: Jakub Jelinek Date: Wed Jun 16 13:10:48 2021 +0200 testsuite: Use noipa attribute instead of noinline, noclone I've noticed this test now on various arches sometimes FAILs, sometimes PASSes (the line 12 test in particular). The problem is that a = 0; initialization in the caller no longer happens before the f(&a) call as what the argument points to is only used in debug info. Making the function noipa forces the caller to initialize it and still tests what the test wants to test, namely that we don't consider *p as valid location for the c variable at line 18 (after it has been overwritten with *p = 1;). 2021-06-16 Jakub Jelinek * gcc.dg/guality/pr49888.c (f): Use noipa attribute instead of noinline, noclone. Diff: --- gcc/testsuite/gcc.dg/guality/pr49888.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/testsuite/gcc.dg/guality/pr49888.c b/gcc/testsuite/gcc.dg/guality/pr49888.c index 4f3a2501eb7..919cfc9c769 100644 --- a/gcc/testsuite/gcc.dg/guality/pr49888.c +++ b/gcc/testsuite/gcc.dg/guality/pr49888.c @@ -4,7 +4,7 @@ static int v __attribute__((used)); -static void __attribute__((noinline, noclone)) +static void __attribute__((noipa)) f (int *p) { int c = *p;