From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1011) id 608BF38618BB; Wed, 16 Jun 2021 17:13:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 608BF38618BB MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Andrew Macleod To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-1539] Avoid loading an undefined value in the ranger_cache constructor. X-Act-Checkin: gcc X-Git-Author: Andrew MacLeod X-Git-Refname: refs/heads/master X-Git-Oldrev: 9e64426dae129cca5b62355ef6c5a3bd6137e830 X-Git-Newrev: bdfc1207bd20cf1ad81fca121e4f7df4995cc0d6 Message-Id: <20210616171306.608BF38618BB@sourceware.org> Date: Wed, 16 Jun 2021 17:13:06 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jun 2021 17:13:06 -0000 https://gcc.gnu.org/g:bdfc1207bd20cf1ad81fca121e4f7df4995cc0d6 commit r12-1539-gbdfc1207bd20cf1ad81fca121e4f7df4995cc0d6 Author: Andrew MacLeod Date: Wed Jun 16 13:01:21 2021 -0400 Avoid loading an undefined value in the ranger_cache constructor. Enable_new_values takes a boolean, returning the old value. The constructor for ranger_cache initialized the m_new_value_p field by calling this routine and ignorng the result. This potentially loads the old value uninitialized. * gimple-range-cache.cc (ranger_cache::ranger_cache): Initialize m_new_value_p directly. Diff: --- gcc/gimple-range-cache.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/gimple-range-cache.cc b/gcc/gimple-range-cache.cc index d9a57c294df..37e2acb19f9 100644 --- a/gcc/gimple-range-cache.cc +++ b/gcc/gimple-range-cache.cc @@ -727,7 +727,7 @@ ranger_cache::ranger_cache (gimple_ranger &q) : query (q) if (bb) m_gori.exports (bb); } - enable_new_values (true); + m_new_value_p = true; } ranger_cache::~ranger_cache ()