public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r11-8596] testsuite: Use noipa attribute instead of noinline, noclone Date: Thu, 17 Jun 2021 05:59:54 +0000 (GMT) [thread overview] Message-ID: <20210617055954.EE8DE3839C44@sourceware.org> (raw) https://gcc.gnu.org/g:79c1185de4a05fdea13b6b020795892913f8184e commit r11-8596-g79c1185de4a05fdea13b6b020795892913f8184e Author: Jakub Jelinek <jakub@redhat.com> Date: Wed Jun 16 13:10:48 2021 +0200 testsuite: Use noipa attribute instead of noinline, noclone I've noticed this test now on various arches sometimes FAILs, sometimes PASSes (the line 12 test in particular). The problem is that a = 0; initialization in the caller no longer happens before the f(&a) call as what the argument points to is only used in debug info. Making the function noipa forces the caller to initialize it and still tests what the test wants to test, namely that we don't consider *p as valid location for the c variable at line 18 (after it has been overwritten with *p = 1;). 2021-06-16 Jakub Jelinek <jakub@redhat.com> * gcc.dg/guality/pr49888.c (f): Use noipa attribute instead of noinline, noclone. (cherry picked from commit a490b1dc0b3c26bff2ee00ac0da2d606d2009e3a) Diff: --- gcc/testsuite/gcc.dg/guality/pr49888.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/testsuite/gcc.dg/guality/pr49888.c b/gcc/testsuite/gcc.dg/guality/pr49888.c index 4f3a2501eb7..919cfc9c769 100644 --- a/gcc/testsuite/gcc.dg/guality/pr49888.c +++ b/gcc/testsuite/gcc.dg/guality/pr49888.c @@ -4,7 +4,7 @@ static int v __attribute__((used)); -static void __attribute__((noinline, noclone)) +static void __attribute__((noipa)) f (int *p) { int c = *p;
reply other threads:[~2021-06-17 5:59 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210617055954.EE8DE3839C44@sourceware.org \ --to=jakub@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).