From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1914) id 6CB1639A047E; Fri, 18 Jun 2021 08:37:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6CB1639A047E MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Pierre-Marie de Rodat To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-1615] [Ada] Update comments related to TBD X-Act-Checkin: gcc X-Git-Author: Arnaud Charlet X-Git-Refname: refs/heads/master X-Git-Oldrev: 26373979deab7481b0503d86e80390ab65c65381 X-Git-Newrev: 4463d6eebc0a160c93a30feb1a5e8025f9a344d8 Message-Id: <20210618083759.6CB1639A047E@sourceware.org> Date: Fri, 18 Jun 2021 08:37:59 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jun 2021 08:37:59 -0000 https://gcc.gnu.org/g:4463d6eebc0a160c93a30feb1a5e8025f9a344d8 commit r12-1615-g4463d6eebc0a160c93a30feb1a5e8025f9a344d8 Author: Arnaud Charlet Date: Mon Mar 15 11:01:38 2021 +0100 [Ada] Update comments related to TBD gcc/ada/ * exp_aggr.adb, exp_dist.adb, exp_unst.adb, sa_messages.ads, sem_ch13.adb, sem_ch3.adb, sem_ch5.adb, sem_eval.adb, sem_util.adb, sem_util.ads, sinfo.ads: Update comments. Diff: --- gcc/ada/exp_aggr.adb | 2 +- gcc/ada/exp_dist.adb | 4 ++-- gcc/ada/exp_unst.adb | 2 +- gcc/ada/sa_messages.ads | 2 +- gcc/ada/sem_ch13.adb | 4 ++-- gcc/ada/sem_ch3.adb | 4 ++-- gcc/ada/sem_ch5.adb | 1 - gcc/ada/sem_eval.adb | 2 +- gcc/ada/sem_util.adb | 2 +- gcc/ada/sem_util.ads | 2 +- gcc/ada/sinfo.ads | 4 ++-- 11 files changed, 14 insertions(+), 15 deletions(-) diff --git a/gcc/ada/exp_aggr.adb b/gcc/ada/exp_aggr.adb index 8376ff712bc..8f3147e5be7 100644 --- a/gcc/ada/exp_aggr.adb +++ b/gcc/ada/exp_aggr.adb @@ -7167,7 +7167,7 @@ package body Exp_Aggr is return Build_Siz_Exp (First (Discrete_Choices (Comp))); elsif Nkind (Comp) = N_Iterated_Element_Association then - return -1; -- TBD, build expression for size of the domain + return -1; -- ??? build expression for size of the domain else return -1; diff --git a/gcc/ada/exp_dist.adb b/gcc/ada/exp_dist.adb index cf908b1ec0d..7fb21325bd5 100644 --- a/gcc/ada/exp_dist.adb +++ b/gcc/ada/exp_dist.adb @@ -10906,8 +10906,8 @@ package body Exp_Dist is raise Program_Error; end if; - -- TBD: fixed point types??? - -- TBverified numeric types with a biased representation??? + -- What about fixed point types and numeric types with a biased + -- representation??? end Find_Numeric_Representation; diff --git a/gcc/ada/exp_unst.adb b/gcc/ada/exp_unst.adb index 8204fdc9bb6..c071a9c7e35 100644 --- a/gcc/ada/exp_unst.adb +++ b/gcc/ada/exp_unst.adb @@ -1566,7 +1566,7 @@ package body Exp_Unst is -- A subprogram instantiation does not have an explicit -- body. If unused, we could remove the corresponding - -- wrapper package and its body (TBD). + -- wrapper package and its body. if Present (STJ.Bod) then Spec := Corresponding_Spec (STJ.Bod); diff --git a/gcc/ada/sa_messages.ads b/gcc/ada/sa_messages.ads index 4963c6d1376..4f4ed8a8668 100644 --- a/gcc/ada/sa_messages.ads +++ b/gcc/ada/sa_messages.ads @@ -96,7 +96,7 @@ package SA_Messages is -- Contract_Cases, Default_Initial_Condition, Initial_Condition, -- Loop_Invariant, Loop_Variant, Refined_Post, and Subprogram_Variant. -- - -- TBD: it might be nice to distinguish these different kinds of assertions + -- It might be nice to distinguish these different kinds of assertions -- as is done in SPARK's VC_Kind enumeration type, but any distinction -- which isn't already present in CP's BE_Message_Subkind enumeration type -- would require more work on the CP side. diff --git a/gcc/ada/sem_ch13.adb b/gcc/ada/sem_ch13.adb index 35e0b9236ab..ec1962985f5 100644 --- a/gcc/ada/sem_ch13.adb +++ b/gcc/ada/sem_ch13.adb @@ -2623,7 +2623,7 @@ package body Sem_Ch13 is end if; end loop; - -- ??? TBD: Must check that "for result type R, if the + -- ??? Must check that "for result type R, if the -- function is a boundary entity for type R (see 7.3.2), -- no type invariant applies to type R; if R has a -- component type C, a similar rule applies to C." @@ -15068,7 +15068,7 @@ package body Sem_Ch13 is -- For now we only deal with aspects that do not generate -- subprograms, or that may mention current instances of - -- types. These will require special handling (???TBD). + -- types. These will require special handling???. when Aspect_Invariant | Aspect_Predicate diff --git a/gcc/ada/sem_ch3.adb b/gcc/ada/sem_ch3.adb index a762a6199f0..346850de21a 100644 --- a/gcc/ada/sem_ch3.adb +++ b/gcc/ada/sem_ch3.adb @@ -2827,7 +2827,7 @@ package body Sem_Ch3 is -- to the first encountered body. -- ??? A cleaner approach may be possible and/or this solution - -- could be extended to general-purpose late primitives, TBD. + -- could be extended to general-purpose late primitives. if Present (Ctrl_Typ) then @@ -3055,7 +3055,7 @@ package body Sem_Ch3 is end if; end if; - -- TBD : other nonoverridable aspects. + -- What about other nonoverridable aspects??? end Check_Nonoverridable_Aspects; ------------------------------------ diff --git a/gcc/ada/sem_ch5.adb b/gcc/ada/sem_ch5.adb index 4574ef986b9..58cf6c22fda 100644 --- a/gcc/ada/sem_ch5.adb +++ b/gcc/ada/sem_ch5.adb @@ -1542,7 +1542,6 @@ package body Sem_Ch5 is elsif Extensions_Allowed and then Is_Overloaded (Exp) then - -- TBD: Generate better ambiguity diagnostics here. -- It would be nice if we could generate all the right error -- messages by calling "Resolve (Exp, Any_Type);" in the -- same way that they are generated a few lines below by the diff --git a/gcc/ada/sem_eval.adb b/gcc/ada/sem_eval.adb index 307045a2124..7a70fd83b2a 100644 --- a/gcc/ada/sem_eval.adb +++ b/gcc/ada/sem_eval.adb @@ -6223,7 +6223,7 @@ package body Sem_Eval is end; else - -- TBD: Implement Interval_Lists for real types + -- ??? Need to implement Interval_Lists for real types return False; end if; diff --git a/gcc/ada/sem_util.adb b/gcc/ada/sem_util.adb index d0e3b1a47c3..f09295baa88 100644 --- a/gcc/ada/sem_util.adb +++ b/gcc/ada/sem_util.adb @@ -25239,7 +25239,7 @@ package body Sem_Util is Domain : constant Node_Id := Name (Parent (Ent)); begin - -- TBD : in the full version of the construct, the + -- ??? In the full version of the construct, the -- domain of iteration can be given by an expression. if Is_Entity_Name (Domain) then diff --git a/gcc/ada/sem_util.ads b/gcc/ada/sem_util.ads index 1d4bd168968..e387d147f62 100644 --- a/gcc/ada/sem_util.ads +++ b/gcc/ada/sem_util.ads @@ -3353,7 +3353,7 @@ package Sem_Util is -- Returns True iff every value belonging to some interval of -- Subset also belongs to some interval of Of_Set. - -- TBD: When we get around to implementing "is statically compatible" + -- When we get around to implementing "is statically compatible" -- correctly for real types with static predicates, we may need -- an analogous Real_Interval_List type. Most of the language -- rules that reference "is statically compatible" pertain to diff --git a/gcc/ada/sinfo.ads b/gcc/ada/sinfo.ads index 5a4bb660443..f210c4916e3 100644 --- a/gcc/ada/sinfo.ads +++ b/gcc/ada/sinfo.ads @@ -1099,7 +1099,7 @@ package Sinfo is -- Do_Accessibility_Check -- This flag is set on N_Parameter_Specification nodes to indicate -- that an accessibility check is required for the parameter. It is - -- not yet decided who takes care of this check (TBD ???). + -- not yet decided who takes care of this check???. -- Do_Discriminant_Check -- This flag is set on N_Selected_Component nodes to indicate that a @@ -1190,7 +1190,7 @@ package Sinfo is -- N_Procedure_Call_Statement, N_Type_Conversion, -- N_Simple_Return_Statement, or N_Extended_Return_Statement -- node to indicate that the tag check can be suppressed. It is not - -- yet decided how this flag is used (TBD ???). + -- yet decided how this flag is used???. -- Elaborate_Present -- This flag is set in the N_With_Clause node to indicate that pragma