From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1914) id C716E39B4413; Fri, 18 Jun 2021 08:38:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C716E39B4413 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Pierre-Marie de Rodat To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-1626] [Ada] Warn about overlapping actuals in all versions of Ada X-Act-Checkin: gcc X-Git-Author: Piotr Trojanek X-Git-Refname: refs/heads/master X-Git-Oldrev: d94a2f5f1fcd1d864d67244157d8b29fbffa14a5 X-Git-Newrev: 1be46d12a7b76e62f25f3e4e148cda3a6c8948c3 Message-Id: <20210618083855.C716E39B4413@sourceware.org> Date: Fri, 18 Jun 2021 08:38:55 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jun 2021 08:38:55 -0000 https://gcc.gnu.org/g:1be46d12a7b76e62f25f3e4e148cda3a6c8948c3 commit r12-1626-g1be46d12a7b76e62f25f3e4e148cda3a6c8948c3 Author: Piotr Trojanek Date: Wed Mar 17 13:36:50 2021 +0100 [Ada] Warn about overlapping actuals in all versions of Ada gcc/ada/ * sem_warn.adb (Warn_On_Overlapping_Actuals): Cleanup conditions related to Ada_Version. Diff: --- gcc/ada/sem_warn.adb | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/gcc/ada/sem_warn.adb b/gcc/ada/sem_warn.adb index 4ec96fc3c9d..23f27711b5a 100644 --- a/gcc/ada/sem_warn.adb +++ b/gcc/ada/sem_warn.adb @@ -3725,11 +3725,6 @@ package body Sem_Warn is -- Start of processing for Warn_On_Overlapping_Actuals begin - - if Ada_Version < Ada_2012 and then not Warn_On_Overlap then - return; - end if; - -- Exclude calls rewritten as enumeration literals if Nkind (N) not in N_Subprogram_Call | N_Entry_Call_Statement then @@ -3823,14 +3818,13 @@ package body Sem_Warn is then null; - -- Under Ada 2012 we only report warnings on overlapping - -- arrays and record types if switch is set. + -- We only report warnings on overlapping arrays and record + -- types if switch is set. - elsif Ada_Version >= Ada_2012 + elsif not Warn_On_Overlap and then not (Is_Elementary_Type (Etype (Form1)) and then Is_Elementary_Type (Etype (Form2))) - and then not Warn_On_Overlap then null; @@ -3844,7 +3838,7 @@ package body Sem_Warn is Ada_Version < Ada_2012 - -- Overlap is only illegal in Ada 2012 in the case of + -- Overlap is only illegal since Ada 2012 and only for -- elementary types (passed by copy). For other types -- we always have a warning in all versions. This is -- clarified by AI12-0216.