public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Pierre-Marie de Rodat <pmderodat@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-1684] [Ada] Address ??? comments Date: Mon, 21 Jun 2021 11:05:54 +0000 (GMT) [thread overview] Message-ID: <20210621110554.38EFE3938C23@sourceware.org> (raw) https://gcc.gnu.org/g:c1f1ef183691543a6dd342803f814252512fa249 commit r12-1684-gc1f1ef183691543a6dd342803f814252512fa249 Author: Ghjuvan Lacambre <lacambre@adacore.com> Date: Sun Mar 28 14:10:53 2021 +0200 [Ada] Address ??? comments gcc/ada/ * exp_ch9.adb (Build_Simple_Entry_Call): Add comment. * libgnat/s-rannum.adb (Random): Update comment. * libgnat/s-rannum.ads (Generator): Update comment. Diff: --- gcc/ada/exp_ch9.adb | 6 +++++- gcc/ada/libgnat/s-rannum.adb | 5 ++++- gcc/ada/libgnat/s-rannum.ads | 4 +++- 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/gcc/ada/exp_ch9.adb b/gcc/ada/exp_ch9.adb index 3948b6a51a3..6b1e284f3fb 100644 --- a/gcc/ada/exp_ch9.adb +++ b/gcc/ada/exp_ch9.adb @@ -282,7 +282,11 @@ package body Exp_Ch9 is Concval : Node_Id; Ename : Node_Id; Index : Node_Id); - -- Some comments here would be useful ??? + -- Build the call corresponding to the task entry call. N is the task entry + -- call, Concval is the concurrent object, Ename is the entry name and + -- Index is the entry family index. + -- Note that N might be expanded into an N_Block_Statement if it gets + -- inlined. function Build_Task_Proc_Specification (T : Entity_Id) return Node_Id; -- This routine constructs a specification for the procedure that we will diff --git a/gcc/ada/libgnat/s-rannum.adb b/gcc/ada/libgnat/s-rannum.adb index 87691676a73..0a1565b83d7 100644 --- a/gcc/ada/libgnat/s-rannum.adb +++ b/gcc/ada/libgnat/s-rannum.adb @@ -178,7 +178,10 @@ is function Random (Gen : Generator) return Unsigned_32 is G : Generator renames Gen.Writable.Self.all; Y : State_Val; - I : Integer; -- should avoid use of identifier I ??? + I : Integer; + -- Naming exception: I is fine to use here as it is the name used in + -- the original paper describing the Mersenne Twister and in common + -- descriptions of the algorithm. begin I := G.I; diff --git a/gcc/ada/libgnat/s-rannum.ads b/gcc/ada/libgnat/s-rannum.ads index 855b5b57d45..370a07989b9 100644 --- a/gcc/ada/libgnat/s-rannum.ads +++ b/gcc/ada/libgnat/s-rannum.ads @@ -162,7 +162,9 @@ private I : Integer := N; -- Current starting position in shift register S (N means uninitialized) - -- We should avoid using the identifier I here ??? + -- Naming exception: I is fine to use here as it is the name used in the + -- original paper describing the Mersenne Twister and in common + -- descriptions of the algorithm. end record; end System.Random_Numbers;
reply other threads:[~2021-06-21 11:05 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210621110554.38EFE3938C23@sourceware.org \ --to=pmderodat@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).