public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Aaron Sawdey <acsawdey@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r11-8646] Do not enable pcrel-opt by default Date: Wed, 23 Jun 2021 20:09:09 +0000 (GMT) [thread overview] Message-ID: <20210623200909.233913835813@sourceware.org> (raw) https://gcc.gnu.org/g:ea2f428bfef43d286e0aa789eccd120d9b829a1e commit r11-8646-gea2f428bfef43d286e0aa789eccd120d9b829a1e Author: Aaron Sawdey <acsawdey@linux.ibm.com> Date: Tue Jun 22 16:02:15 2021 -0500 Do not enable pcrel-opt by default Backported from trunk. SPEC2017 testing on p10 shows that this optimization does not have a positive impact on performance. So we are no longer going to enable it by default. The test cases for it needed to be updated so they always enable it to test it. gcc/ * config/rs6000/rs6000-cpus.def: Take OPTION_MASK_PCREL_OPT out of OTHER_POWER10_MASKS so it will not be enabled by default. gcc/testsuite/ * gcc.target/powerpc/pcrel-opt-inc-di.c: Enable -mpcrel-opt to test it. * gcc.target/powerpc/pcrel-opt-ld-df.c: Enable -mpcrel-opt to test it. * gcc.target/powerpc/pcrel-opt-ld-di.c: Enable -mpcrel-opt to test it. * gcc.target/powerpc/pcrel-opt-ld-hi.c: Enable -mpcrel-opt to test it. * gcc.target/powerpc/pcrel-opt-ld-qi.c: Enable -mpcrel-opt to test it. * gcc.target/powerpc/pcrel-opt-ld-sf.c: Enable -mpcrel-opt to test it. * gcc.target/powerpc/pcrel-opt-ld-si.c: Enable -mpcrel-opt to test it. * gcc.target/powerpc/pcrel-opt-ld-vector.c: Enable -mpcrel-opt to test it. * gcc.target/powerpc/pcrel-opt-st-df.c: Enable -mpcrel-opt to test it. * gcc.target/powerpc/pcrel-opt-st-di.c: Enable -mpcrel-opt to test it. * gcc.target/powerpc/pcrel-opt-st-hi.c: Enable -mpcrel-opt to test it. * gcc.target/powerpc/pcrel-opt-st-qi.c: Enable -mpcrel-opt to test it. * gcc.target/powerpc/pcrel-opt-st-sf.c: Enable -mpcrel-opt to test it. * gcc.target/powerpc/pcrel-opt-st-si.c: Enable -mpcrel-opt to test it. * gcc.target/powerpc/pcrel-opt-st-vector.c: Enable -mpcrel-opt to test it. (cherry picked from commit b7574ca6edb5ac7fab741f46d4f50ac4294c8180) Diff: --- gcc/config/rs6000/rs6000-cpus.def | 4 +++- gcc/testsuite/gcc.target/powerpc/pcrel-opt-inc-di.c | 2 +- gcc/testsuite/gcc.target/powerpc/pcrel-opt-ld-df.c | 2 +- gcc/testsuite/gcc.target/powerpc/pcrel-opt-ld-di.c | 2 +- gcc/testsuite/gcc.target/powerpc/pcrel-opt-ld-hi.c | 2 +- gcc/testsuite/gcc.target/powerpc/pcrel-opt-ld-qi.c | 2 +- gcc/testsuite/gcc.target/powerpc/pcrel-opt-ld-sf.c | 2 +- gcc/testsuite/gcc.target/powerpc/pcrel-opt-ld-si.c | 2 +- gcc/testsuite/gcc.target/powerpc/pcrel-opt-ld-vector.c | 2 +- gcc/testsuite/gcc.target/powerpc/pcrel-opt-st-df.c | 2 +- gcc/testsuite/gcc.target/powerpc/pcrel-opt-st-di.c | 2 +- gcc/testsuite/gcc.target/powerpc/pcrel-opt-st-hi.c | 2 +- gcc/testsuite/gcc.target/powerpc/pcrel-opt-st-qi.c | 2 +- gcc/testsuite/gcc.target/powerpc/pcrel-opt-st-sf.c | 2 +- gcc/testsuite/gcc.target/powerpc/pcrel-opt-st-si.c | 2 +- gcc/testsuite/gcc.target/powerpc/pcrel-opt-st-vector.c | 2 +- 16 files changed, 18 insertions(+), 16 deletions(-) diff --git a/gcc/config/rs6000/rs6000-cpus.def b/gcc/config/rs6000/rs6000-cpus.def index 52ce84835f7..6758296c0fd 100644 --- a/gcc/config/rs6000/rs6000-cpus.def +++ b/gcc/config/rs6000/rs6000-cpus.def @@ -75,9 +75,11 @@ | OPTION_MASK_P9_VECTOR) /* Flags that need to be turned off if -mno-power10. */ +/* We comment out PCREL_OPT here to disable it by default because SPEC2017 + performance was degraded by it. */ #define OTHER_POWER10_MASKS (OPTION_MASK_MMA \ | OPTION_MASK_PCREL \ - | OPTION_MASK_PCREL_OPT \ + /* | OPTION_MASK_PCREL_OPT */ \ | OPTION_MASK_PREFIXED) #define ISA_3_1_MASKS_SERVER (ISA_3_0_MASKS_SERVER \ diff --git a/gcc/testsuite/gcc.target/powerpc/pcrel-opt-inc-di.c b/gcc/testsuite/gcc.target/powerpc/pcrel-opt-inc-di.c index c82041c9dc6..6272f5c72c3 100644 --- a/gcc/testsuite/gcc.target/powerpc/pcrel-opt-inc-di.c +++ b/gcc/testsuite/gcc.target/powerpc/pcrel-opt-inc-di.c @@ -1,6 +1,6 @@ /* { dg-do compile } */ /* { dg-require-effective-target powerpc_pcrel } */ -/* { dg-options "-O2 -mdejagnu-cpu=power10" } */ +/* { dg-options "-O2 -mdejagnu-cpu=power10 -mpcrel-opt" } */ #define TYPE unsigned int diff --git a/gcc/testsuite/gcc.target/powerpc/pcrel-opt-ld-df.c b/gcc/testsuite/gcc.target/powerpc/pcrel-opt-ld-df.c index d35862fcb6e..0dcab311add 100644 --- a/gcc/testsuite/gcc.target/powerpc/pcrel-opt-ld-df.c +++ b/gcc/testsuite/gcc.target/powerpc/pcrel-opt-ld-df.c @@ -1,6 +1,6 @@ /* { dg-do compile } */ /* { dg-require-effective-target powerpc_pcrel } */ -/* { dg-options "-O2 -mdejagnu-cpu=power10" } */ +/* { dg-options "-O2 -mdejagnu-cpu=power10 -mpcrel-opt" } */ #define TYPE double #define LARGE 0x20000 diff --git a/gcc/testsuite/gcc.target/powerpc/pcrel-opt-ld-di.c b/gcc/testsuite/gcc.target/powerpc/pcrel-opt-ld-di.c index 7e1ff99f20e..95b60f3b151 100644 --- a/gcc/testsuite/gcc.target/powerpc/pcrel-opt-ld-di.c +++ b/gcc/testsuite/gcc.target/powerpc/pcrel-opt-ld-di.c @@ -1,6 +1,6 @@ /* { dg-do compile } */ /* { dg-require-effective-target powerpc_pcrel } */ -/* { dg-options "-O2 -mdejagnu-cpu=power10" } */ +/* { dg-options "-O2 -mdejagnu-cpu=power10 -mpcrel-opt" } */ #define TYPE long long #define LARGE 0x20000 diff --git a/gcc/testsuite/gcc.target/powerpc/pcrel-opt-ld-hi.c b/gcc/testsuite/gcc.target/powerpc/pcrel-opt-ld-hi.c index 4143aeb7371..4a62dfbdf6e 100644 --- a/gcc/testsuite/gcc.target/powerpc/pcrel-opt-ld-hi.c +++ b/gcc/testsuite/gcc.target/powerpc/pcrel-opt-ld-hi.c @@ -1,6 +1,6 @@ /* { dg-do compile } */ /* { dg-require-effective-target powerpc_pcrel } */ -/* { dg-options "-O2 -mdejagnu-cpu=power10" } */ +/* { dg-options "-O2 -mdejagnu-cpu=power10 -mpcrel-opt" } */ #define TYPE unsigned short #define LARGE 0x20000 diff --git a/gcc/testsuite/gcc.target/powerpc/pcrel-opt-ld-qi.c b/gcc/testsuite/gcc.target/powerpc/pcrel-opt-ld-qi.c index 30d3236f95c..3a7aad45b55 100644 --- a/gcc/testsuite/gcc.target/powerpc/pcrel-opt-ld-qi.c +++ b/gcc/testsuite/gcc.target/powerpc/pcrel-opt-ld-qi.c @@ -1,6 +1,6 @@ /* { dg-do compile } */ /* { dg-require-effective-target powerpc_pcrel } */ -/* { dg-options "-O2 -mdejagnu-cpu=power10" } */ +/* { dg-options "-O2 -mdejagnu-cpu=power10 -mpcrel-opt" } */ #define TYPE unsigned char #define LARGE 0x20000 diff --git a/gcc/testsuite/gcc.target/powerpc/pcrel-opt-ld-sf.c b/gcc/testsuite/gcc.target/powerpc/pcrel-opt-ld-sf.c index 9d1e2a1956f..cb76bed04b8 100644 --- a/gcc/testsuite/gcc.target/powerpc/pcrel-opt-ld-sf.c +++ b/gcc/testsuite/gcc.target/powerpc/pcrel-opt-ld-sf.c @@ -1,6 +1,6 @@ /* { dg-do compile } */ /* { dg-require-effective-target powerpc_pcrel } */ -/* { dg-options "-O2 -mdejagnu-cpu=power10" } */ +/* { dg-options "-O2 -mdejagnu-cpu=power10 -mpcrel-opt" } */ #define TYPE float #define LARGE 0x20000 diff --git a/gcc/testsuite/gcc.target/powerpc/pcrel-opt-ld-si.c b/gcc/testsuite/gcc.target/powerpc/pcrel-opt-ld-si.c index 17be6fa1778..ad011d61448 100644 --- a/gcc/testsuite/gcc.target/powerpc/pcrel-opt-ld-si.c +++ b/gcc/testsuite/gcc.target/powerpc/pcrel-opt-ld-si.c @@ -1,6 +1,6 @@ /* { dg-do compile } */ /* { dg-require-effective-target powerpc_pcrel } */ -/* { dg-options "-O2 -mdejagnu-cpu=power10" } */ +/* { dg-options "-O2 -mdejagnu-cpu=power10 -mpcrel-opt" } */ #define TYPE int #define LARGE 0x20000 diff --git a/gcc/testsuite/gcc.target/powerpc/pcrel-opt-ld-vector.c b/gcc/testsuite/gcc.target/powerpc/pcrel-opt-ld-vector.c index 8c12aea5acd..c8f70b5d433 100644 --- a/gcc/testsuite/gcc.target/powerpc/pcrel-opt-ld-vector.c +++ b/gcc/testsuite/gcc.target/powerpc/pcrel-opt-ld-vector.c @@ -1,6 +1,6 @@ /* { dg-do compile } */ /* { dg-require-effective-target powerpc_pcrel } */ -/* { dg-options "-O2 -mdejagnu-cpu=power10" } */ +/* { dg-options "-O2 -mdejagnu-cpu=power10 -mpcrel-opt" } */ #define TYPE vector double #define LARGE 0x20000 diff --git a/gcc/testsuite/gcc.target/powerpc/pcrel-opt-st-df.c b/gcc/testsuite/gcc.target/powerpc/pcrel-opt-st-df.c index d795d35d8de..686a3761462 100644 --- a/gcc/testsuite/gcc.target/powerpc/pcrel-opt-st-df.c +++ b/gcc/testsuite/gcc.target/powerpc/pcrel-opt-st-df.c @@ -1,6 +1,6 @@ /* { dg-do compile } */ /* { dg-require-effective-target powerpc_pcrel } */ -/* { dg-options "-O2 -mdejagnu-cpu=power10" } */ +/* { dg-options "-O2 -mdejagnu-cpu=power10 -mpcrel-opt" } */ #define TYPE double #define LARGE 0x20000 diff --git a/gcc/testsuite/gcc.target/powerpc/pcrel-opt-st-di.c b/gcc/testsuite/gcc.target/powerpc/pcrel-opt-st-di.c index bf57de4b886..fefe6d30e01 100644 --- a/gcc/testsuite/gcc.target/powerpc/pcrel-opt-st-di.c +++ b/gcc/testsuite/gcc.target/powerpc/pcrel-opt-st-di.c @@ -1,6 +1,6 @@ /* { dg-do compile } */ /* { dg-require-effective-target powerpc_pcrel } */ -/* { dg-options "-O2 -mdejagnu-cpu=power10" } */ +/* { dg-options "-O2 -mdejagnu-cpu=power10 -mpcrel-opt" } */ #define TYPE long long #define LARGE 0x20000 diff --git a/gcc/testsuite/gcc.target/powerpc/pcrel-opt-st-hi.c b/gcc/testsuite/gcc.target/powerpc/pcrel-opt-st-hi.c index 8822e767dfe..d2856863da7 100644 --- a/gcc/testsuite/gcc.target/powerpc/pcrel-opt-st-hi.c +++ b/gcc/testsuite/gcc.target/powerpc/pcrel-opt-st-hi.c @@ -1,6 +1,6 @@ /* { dg-do compile } */ /* { dg-require-effective-target powerpc_pcrel } */ -/* { dg-options "-O2 -mdejagnu-cpu=power10" } */ +/* { dg-options "-O2 -mdejagnu-cpu=power10 -mpcrel-opt" } */ #define TYPE unsigned short #define LARGE 0x20000 diff --git a/gcc/testsuite/gcc.target/powerpc/pcrel-opt-st-qi.c b/gcc/testsuite/gcc.target/powerpc/pcrel-opt-st-qi.c index 2f756833717..f617ffc6adf 100644 --- a/gcc/testsuite/gcc.target/powerpc/pcrel-opt-st-qi.c +++ b/gcc/testsuite/gcc.target/powerpc/pcrel-opt-st-qi.c @@ -1,6 +1,6 @@ /* { dg-do compile } */ /* { dg-require-effective-target powerpc_pcrel } */ -/* { dg-options "-O2 -mdejagnu-cpu=power10" } */ +/* { dg-options "-O2 -mdejagnu-cpu=power10 -mpcrel-opt" } */ #define TYPE unsigned char #define LARGE 0x20000 diff --git a/gcc/testsuite/gcc.target/powerpc/pcrel-opt-st-sf.c b/gcc/testsuite/gcc.target/powerpc/pcrel-opt-st-sf.c index 3dd88aad856..6eb20a3e047 100644 --- a/gcc/testsuite/gcc.target/powerpc/pcrel-opt-st-sf.c +++ b/gcc/testsuite/gcc.target/powerpc/pcrel-opt-st-sf.c @@ -1,6 +1,6 @@ /* { dg-do compile } */ /* { dg-require-effective-target powerpc_pcrel } */ -/* { dg-options "-O2 -mdejagnu-cpu=power10" } */ +/* { dg-options "-O2 -mdejagnu-cpu=power10 -mpcrel-opt" } */ #define TYPE float #define LARGE 0x20000 diff --git a/gcc/testsuite/gcc.target/powerpc/pcrel-opt-st-si.c b/gcc/testsuite/gcc.target/powerpc/pcrel-opt-st-si.c index 78dc8120efe..0cc0b304dd0 100644 --- a/gcc/testsuite/gcc.target/powerpc/pcrel-opt-st-si.c +++ b/gcc/testsuite/gcc.target/powerpc/pcrel-opt-st-si.c @@ -1,6 +1,6 @@ /* { dg-do compile } */ /* { dg-require-effective-target powerpc_pcrel } */ -/* { dg-options "-O2 -mdejagnu-cpu=power10" } */ +/* { dg-options "-O2 -mdejagnu-cpu=power10 -mpcrel-opt" } */ #define TYPE int #define LARGE 0x20000 diff --git a/gcc/testsuite/gcc.target/powerpc/pcrel-opt-st-vector.c b/gcc/testsuite/gcc.target/powerpc/pcrel-opt-st-vector.c index 2c602eb3103..d760819cfd2 100644 --- a/gcc/testsuite/gcc.target/powerpc/pcrel-opt-st-vector.c +++ b/gcc/testsuite/gcc.target/powerpc/pcrel-opt-st-vector.c @@ -1,6 +1,6 @@ /* { dg-do compile } */ /* { dg-require-effective-target powerpc_pcrel } */ -/* { dg-options "-O2 -mdejagnu-cpu=power10" } */ +/* { dg-options "-O2 -mdejagnu-cpu=power10 -mpcrel-opt" } */ #define TYPE vector double #define LARGE 0x20000
reply other threads:[~2021-06-23 20:09 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210623200909.233913835813@sourceware.org \ --to=acsawdey@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).