public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r12-2373] Fix PR 101453: ICE with optimize and large integer constant
@ 2021-07-16 18:58 Andrew Pinski
0 siblings, 0 replies; only message in thread
From: Andrew Pinski @ 2021-07-16 18:58 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:e06b1c5ac00b1bd0339739d3d9377c90852a83c9
commit r12-2373-ge06b1c5ac00b1bd0339739d3d9377c90852a83c9
Author: Andrew Pinski <apinski@marvell.com>
Date: Thu Jul 15 18:07:09 2021 -0700
Fix PR 101453: ICE with optimize and large integer constant
The problem is the buffer is too small to hold "-O" and
the interger. This fixes the problem by use the correct size
instead.
Changes since v1:
* v2: Use HOST_BITS_PER_LONG and just divide by 3 instead of
3.32.
OK? Bootstrapped and tested on x86_64-linux with no regressions.
gcc/c-family/ChangeLog:
PR c/101453
* c-common.c (parse_optimize_options): Use the correct
size for buffer.
Diff:
---
gcc/c-family/c-common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/c-family/c-common.c b/gcc/c-family/c-common.c
index 681fcc972f4..fe3657b9e74 100644
--- a/gcc/c-family/c-common.c
+++ b/gcc/c-family/c-common.c
@@ -5798,7 +5798,7 @@ parse_optimize_options (tree args, bool attr_p)
if (TREE_CODE (value) == INTEGER_CST)
{
- char buffer[20];
+ char buffer[HOST_BITS_PER_LONG / 3 + 4];
sprintf (buffer, "-O%ld", (long) TREE_INT_CST_LOW (value));
vec_safe_push (optimize_args, ggc_strdup (buffer));
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-07-16 18:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-16 18:58 [gcc r12-2373] Fix PR 101453: ICE with optimize and large integer constant Andrew Pinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).