From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1666) id 63D483948827; Mon, 19 Jul 2021 12:21:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 63D483948827 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Richard Biener To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-2393] tree-optimization/101505 - properly determine stmt precision for PHIs X-Act-Checkin: gcc X-Git-Author: Richard Biener X-Git-Refname: refs/heads/master X-Git-Oldrev: 9f2bc5077debef2b046b6c10d38591ac324ad8b5 X-Git-Newrev: 8df3ee8f7d85d0708f3c3ca96b55c9230c2ae9f0 Message-Id: <20210719122149.63D483948827@sourceware.org> Date: Mon, 19 Jul 2021 12:21:49 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jul 2021 12:21:49 -0000 https://gcc.gnu.org/g:8df3ee8f7d85d0708f3c3ca96b55c9230c2ae9f0 commit r12-2393-g8df3ee8f7d85d0708f3c3ca96b55c9230c2ae9f0 Author: Richard Biener Date: Mon Jul 19 13:29:16 2021 +0200 tree-optimization/101505 - properly determine stmt precision for PHIs Loop vectorization pattern recog fails to walk PHIs when determining stmt precisions. This fails to recognize non-mask uses for bools in PHIs and outer loop vectorization. 2021-07-19 Richard Biener PR tree-optimization/101505 * tree-vect-patterns.c (vect_determine_precisions): Walk PHIs also for loop vectorization. * gcc.dg/vect/pr101505.c: New testcase. Diff: --- gcc/testsuite/gcc.dg/vect/pr101505.c | 16 ++++++++++++++++ gcc/tree-vect-patterns.c | 14 ++++++++++++++ 2 files changed, 30 insertions(+) diff --git a/gcc/testsuite/gcc.dg/vect/pr101505.c b/gcc/testsuite/gcc.dg/vect/pr101505.c new file mode 100644 index 00000000000..e2b8945a5cc --- /dev/null +++ b/gcc/testsuite/gcc.dg/vect/pr101505.c @@ -0,0 +1,16 @@ +/* { dg-do compile } */ +/* { dg-additional-options "-O1" } */ + +int n2; + +__attribute__ ((simd)) char +w7 (void) +{ + short int xb = n2; + int qp; + + for (qp = 0; qp < 2; ++qp) + xb = xb < 1; + + return xb; +} diff --git a/gcc/tree-vect-patterns.c b/gcc/tree-vect-patterns.c index c2494446183..44f6c9b2bd6 100644 --- a/gcc/tree-vect-patterns.c +++ b/gcc/tree-vect-patterns.c @@ -5355,6 +5355,13 @@ vect_determine_precisions (vec_info *vinfo) for (unsigned int i = 0; i < nbbs; i++) { basic_block bb = bbs[i]; + for (auto gsi = gsi_start_phis (bb); + !gsi_end_p (gsi); gsi_next (&gsi)) + { + stmt_vec_info stmt_info = vinfo->lookup_stmt (gsi.phi ()); + if (stmt_info) + vect_determine_mask_precision (vinfo, stmt_info); + } for (auto si = gsi_start_bb (bb); !gsi_end_p (si); gsi_next (&si)) if (!is_gimple_debug (gsi_stmt (si))) vect_determine_mask_precision @@ -5368,6 +5375,13 @@ vect_determine_precisions (vec_info *vinfo) if (!is_gimple_debug (gsi_stmt (si))) vect_determine_stmt_precisions (vinfo, vinfo->lookup_stmt (gsi_stmt (si))); + for (auto gsi = gsi_start_phis (bb); + !gsi_end_p (gsi); gsi_next (&gsi)) + { + stmt_vec_info stmt_info = vinfo->lookup_stmt (gsi.phi ()); + if (stmt_info) + vect_determine_stmt_precisions (vinfo, stmt_info); + } } } else