public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Martin Liska <marxin@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r12-2686] Fix bashism in `libsanitizer/configure.tgt'
Date: Tue,  3 Aug 2021 11:25:10 +0000 (GMT)	[thread overview]
Message-ID: <20210803112510.CA6BE3938C18@sourceware.org> (raw)

https://gcc.gnu.org/g:759f3854f0fdb4add2961bfafd1ee793f392f70a

commit r12-2686-g759f3854f0fdb4add2961bfafd1ee793f392f70a
Author: Mosè Giordano <mose@gnu.org>
Date:   Fri Jun 18 23:46:44 2021 +0000

    Fix bashism in `libsanitizer/configure.tgt'
    
    Appending to a string variable with `+=' is a bashism and does not work in
    strict POSIX shells like dash.  This results in the extra compilation flags not
    to be set correctly.  This patch replaces the `+=' syntax with a simple string
    interpolation to append to the `EXTRA_CXXFLAGS' variable.
    
    libsanitizer/ChangeLog
    
            PR sanitizer/101111
            * configure.tgt: Fix bashism in setting of `EXTRA_CXXFLAGS'.

Diff:
---
 libsanitizer/configure.tgt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libsanitizer/configure.tgt b/libsanitizer/configure.tgt
index f635e412bdc..5a59ea6a1b5 100644
--- a/libsanitizer/configure.tgt
+++ b/libsanitizer/configure.tgt
@@ -70,7 +70,7 @@ case "${target}" in
 	;;
   x86_64-*-darwin2* | x86_64-*-darwin1[2-9]* | i?86-*-darwin1[2-9]*)
 	TSAN_SUPPORTED=no
-	EXTRA_CXXFLAGS+="-Wl,-undefined,dynamic_lookup"
+	EXTRA_CXXFLAGS="${EXTRA_CXXFLAGS} -Wl,-undefined,dynamic_lookup"
 	;;
   x86_64-*-solaris2.11* | i?86-*-solaris2.11*)
 	;;


                 reply	other threads:[~2021-08-03 11:25 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210803112510.CA6BE3938C18@sourceware.org \
    --to=marxin@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).