From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2181) id 222753857007; Thu, 19 Aug 2021 13:57:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 222753857007 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Jonathan Wakely To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org Subject: [gcc r12-3025] libstdc++: Don't check always-true condition [PR101965] X-Act-Checkin: gcc X-Git-Author: Jonathan Wakely X-Git-Refname: refs/heads/master X-Git-Oldrev: 4285ca3e1c4a6c9540dcdf1c4a71b99aba9bbfe8 X-Git-Newrev: 85a709595005b5df4b2ee9d81717a5df19c0023f Message-Id: <20210819135749.222753857007@sourceware.org> Date: Thu, 19 Aug 2021 13:57:49 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Aug 2021 13:57:49 -0000 https://gcc.gnu.org/g:85a709595005b5df4b2ee9d81717a5df19c0023f commit r12-3025-g85a709595005b5df4b2ee9d81717a5df19c0023f Author: Jonathan Wakely Date: Thu Aug 19 13:05:54 2021 +0100 libstdc++: Don't check always-true condition [PR101965] Signed-off-by: Jonathan Wakely libstdc++-v3/ChangeLog: PR libstdc++/101965 * include/std/charconv (__to_chars_i): Remove redundant check. Diff: --- libstdc++-v3/include/std/charconv | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libstdc++-v3/include/std/charconv b/libstdc++-v3/include/std/charconv index ac9c34d4601..2e368843fc9 100644 --- a/libstdc++-v3/include/std/charconv +++ b/libstdc++-v3/include/std/charconv @@ -336,12 +336,10 @@ namespace __detail *__first = '0'; return { __first + 1, errc{} }; } - - if _GLIBCXX17_CONSTEXPR (std::is_signed<_Tp>::value) + else if _GLIBCXX17_CONSTEXPR (std::is_signed<_Tp>::value) if (__value < 0) { - if (__builtin_expect(__first != __last, 1)) - *__first++ = '-'; + *__first++ = '-'; __unsigned_val = _Up(~__value) + _Up(1); }