From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1251) id 053373857406; Tue, 24 Aug 2021 02:00:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 053373857406 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Roger Sayle To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-3104] [Committed] PR middle-end/102029: Stricter typing in LSHIFT_EXPR sign folding. X-Act-Checkin: gcc X-Git-Author: Roger Sayle X-Git-Refname: refs/heads/master X-Git-Oldrev: 819b7c3a339e3bdaf85cd55954c5536bd98aae09 X-Git-Newrev: 78fa5112b4c2dcd94b78ee79baddebbf14d6ad98 Message-Id: <20210824020011.053373857406@sourceware.org> Date: Tue, 24 Aug 2021 02:00:11 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Aug 2021 02:00:11 -0000 https://gcc.gnu.org/g:78fa5112b4c2dcd94b78ee79baddebbf14d6ad98 commit r12-3104-g78fa5112b4c2dcd94b78ee79baddebbf14d6ad98 Author: Roger Sayle Date: Tue Aug 24 02:59:02 2021 +0100 [Committed] PR middle-end/102029: Stricter typing in LSHIFT_EXPR sign folding. My sincere apologies to everyone (again). As diagnosed by Jakub Jelinek, my recent patch to fold the signedness of LSHIFT_EXPR needs to be careful not to attempt transforming a left shift in an integer type into an invalid left shift of a pointer type. 2021-08-24 Roger Sayle Jakub Jelinek gcc/ChangeLog PR middle-end/102029 * match.pd (shift transformations): Add an additional check for !POINTER_TYPE_P in the recently added left shift transformation. gcc/testsuite/ChangeLog PR middle-end/102029 * gcc.dg/fold-convlshift-3.c: New test case. Diff: --- gcc/match.pd | 4 +++- gcc/testsuite/gcc.dg/fold-convlshift-3.c | 8 ++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/gcc/match.pd b/gcc/match.pd index 978a1b0172e..e5bbb123a6a 100644 --- a/gcc/match.pd +++ b/gcc/match.pd @@ -3389,7 +3389,9 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) the form that minimizes the number of conversions. */ (simplify (convert (lshift:s@0 (convert:s@1 @2) INTEGER_CST@3)) - (if (tree_nop_conversion_p (type, TREE_TYPE (@0)) + (if (INTEGRAL_TYPE_P (type) + && !POINTER_TYPE_P (type) + && tree_nop_conversion_p (type, TREE_TYPE (@0)) && INTEGRAL_TYPE_P (TREE_TYPE (@2)) && TYPE_PRECISION (TREE_TYPE (@2)) <= TYPE_PRECISION (type)) (lshift (convert @2) @3))) diff --git a/gcc/testsuite/gcc.dg/fold-convlshift-3.c b/gcc/testsuite/gcc.dg/fold-convlshift-3.c new file mode 100644 index 00000000000..8d01191f197 --- /dev/null +++ b/gcc/testsuite/gcc.dg/fold-convlshift-3.c @@ -0,0 +1,8 @@ +/* PR middle-end/102029 */ +/* { dg-do compile } */ +/* { dg-options "-O2" } */ +int * +foo (const __PTRDIFF_TYPE__ l) +{ + return (int *) (l << 2); +}