From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1314) id 421223858D35; Mon, 30 Aug 2021 20:54:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 421223858D35 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Andrew Pinski To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-3232] Fix PR 90142: contrib/download_prerequisites uses test == X-Act-Checkin: gcc X-Git-Author: Andrew Pinski X-Git-Refname: refs/heads/trunk X-Git-Oldrev: e18e56c76be35e6a799e07a01c24e0fff3eb1978 X-Git-Newrev: 79a017c412b412f26ec39e0ada75e247fcff5611 Message-Id: <20210830205405.421223858D35@sourceware.org> Date: Mon, 30 Aug 2021 20:54:05 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Aug 2021 20:54:05 -0000 https://gcc.gnu.org/g:79a017c412b412f26ec39e0ada75e247fcff5611 commit r12-3232-g79a017c412b412f26ec39e0ada75e247fcff5611 Author: Andrew Pinski Date: Mon Aug 30 20:30:41 2021 +0000 Fix PR 90142: contrib/download_prerequisites uses test == Since == is not portable, it is better to use = in contrib/ download_prerequisites. The only place == was used is inside the function md5_check which is used only on Mac OS X. Tested on Mac OS X as: ./contrib/download_prerequisites --md5 Both with all files having the correct checksum and one with a broken one. contrib/ChangeLog: * download_prerequisites (md5_check): Replace == inside test with = to be more portable. Diff: --- contrib/download_prerequisites | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/download_prerequisites b/contrib/download_prerequisites index 8f69b61f5a9..11c283ecb1a 100755 --- a/contrib/download_prerequisites +++ b/contrib/download_prerequisites @@ -113,7 +113,7 @@ md5_check() { md5_checksum_output=$(md5 -r "${file_to_check}") # Grab the text before the first space md5_checksum_detected="${md5_checksum_output%% *}" - [ "${md5_checksum_expected}" == "${md5_checksum_detected}" ] \ + [ "${md5_checksum_expected}" = "${md5_checksum_detected}" ] \ || die "Cannot verify integrity of possibly corrupted file ${file_to_check}" echo "${file_to_check}: OK" }