public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jason Merrill <jason@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r12-3235] c++: preserve location through constexpr
Date: Mon, 30 Aug 2021 21:25:21 +0000 (GMT)	[thread overview]
Message-ID: <20210830212521.9CA253858C3B@sourceware.org> (raw)

https://gcc.gnu.org/g:729f6881cfcc6df3c15a1dd4ebd45bc46bb8f3e9

commit r12-3235-g729f6881cfcc6df3c15a1dd4ebd45bc46bb8f3e9
Author: Jason Merrill <jason@redhat.com>
Date:   Sat Aug 28 00:40:29 2021 -0400

    c++: preserve location through constexpr
    
    While working on the patch for PR101460, I noticed that we were losing the
    expression location when folding class prvalue expressions.  The final patch
    doesn't fold class prvalues, but this still seems a worthwhile change.  I
    don't add location wrappers for scalar prvalues because many callers are
    trying to fold them away.
    
    gcc/cp/ChangeLog:
    
            * constexpr.c (cxx_eval_outermost_constant_expr): Copy
            expr location to result.

Diff:
---
 gcc/cp/constexpr.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/gcc/cp/constexpr.c b/gcc/cp/constexpr.c
index 9606719bc73..e78fdf021b2 100644
--- a/gcc/cp/constexpr.c
+++ b/gcc/cp/constexpr.c
@@ -7445,6 +7445,11 @@ cxx_eval_outermost_constant_expr (tree t, bool allow_non_constant,
 	}
     }
 
+  /* Remember the original location if that wouldn't need a wrapper.  */
+  if (location_t loc = EXPR_LOCATION (t))
+    if (CAN_HAVE_LOCATION_P (r))
+      SET_EXPR_LOCATION (r, loc);
+
   return r;
 }


                 reply	other threads:[~2021-08-30 21:25 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210830212521.9CA253858C3B@sourceware.org \
    --to=jason@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).