From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1666) id C405C3858428; Tue, 31 Aug 2021 09:38:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C405C3858428 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Richard Biener To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-3248] middle-end/102129 - avoid TER of possibly trapping expressions X-Act-Checkin: gcc X-Git-Author: Richard Biener X-Git-Refname: refs/heads/master X-Git-Oldrev: dd779c509e56d9300ceb03e3b009d5e0411380b8 X-Git-Newrev: 5e57bacf6f3599efea7634470db84121641c80b0 Message-Id: <20210831093824.C405C3858428@sourceware.org> Date: Tue, 31 Aug 2021 09:38:24 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Aug 2021 09:38:24 -0000 https://gcc.gnu.org/g:5e57bacf6f3599efea7634470db84121641c80b0 commit r12-3248-g5e57bacf6f3599efea7634470db84121641c80b0 Author: Richard Biener Date: Tue Aug 31 09:13:20 2021 +0200 middle-end/102129 - avoid TER of possibly trapping expressions The following avoids applying TER to possibly trapping expressions, preventing a trapping FP multiplication to be moved across a call that should not be executed. 2021-08-31 Richard Biener PR middle-end/102129 * tree-ssa-ter.c (find_replaceable_in_bb): Do not move possibly trapping expressions across calls. Diff: --- gcc/tree-ssa-ter.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/gcc/tree-ssa-ter.c b/gcc/tree-ssa-ter.c index 9eb8a11a7c0..3a057c2d25f 100644 --- a/gcc/tree-ssa-ter.c +++ b/gcc/tree-ssa-ter.c @@ -658,11 +658,15 @@ find_replaceable_in_bb (temp_expr_table *tab, basic_block bb) substitution list, or the def and use span a call such that we'll expand lifetimes across a call. We also don't want to replace across these expressions that may call libcalls that - clobber the register involved. See PR 70184. */ + clobber the register involved. See PR 70184. Neither + do we want to move possibly trapping expressions across + a call. See PRs 102129 and 33593. */ if (gimple_has_volatile_ops (stmt) || same_root_var || (tab->call_cnt[ver] != cur_call_cnt - && SINGLE_SSA_USE_OPERAND (SSA_NAME_DEF_STMT (use), SSA_OP_USE) - == NULL_USE_OPERAND_P) + && (SINGLE_SSA_USE_OPERAND (SSA_NAME_DEF_STMT (use), + SSA_OP_USE) + == NULL_USE_OPERAND_P + || gimple_could_trap_p (SSA_NAME_DEF_STMT (use)))) || tab->reg_vars_cnt[ver] != cur_reg_vars_cnt) finished_with_expr (tab, ver, true); else