From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1314) id 91DE0384B13A; Fri, 3 Sep 2021 16:57:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 91DE0384B13A MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Andrew Pinski To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-3348] Fix some GC issues in the aarch64 back-end. X-Act-Checkin: gcc X-Git-Author: Andrew Pinski X-Git-Refname: refs/heads/trunk X-Git-Oldrev: 8af8abfbbace49e6e5e9413d4e661533437106a0 X-Git-Newrev: 98f1dd0212d57659d1234914791f51ca9f3aba89 Message-Id: <20210903165723.91DE0384B13A@sourceware.org> Date: Fri, 3 Sep 2021 16:57:23 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Sep 2021 16:57:23 -0000 https://gcc.gnu.org/g:98f1dd0212d57659d1234914791f51ca9f3aba89 commit r12-3348-g98f1dd0212d57659d1234914791f51ca9f3aba89 Author: Andrew Pinski Date: Fri Sep 3 02:12:29 2021 +0000 Fix some GC issues in the aarch64 back-end. I got some ICEs in my latest testsing while running the libstdc++ testsuite. I had noticed the problem was connected to types and had just touched the builtins code but nothing which could have caused this and I looked for some types/variables that were not being marked with GTY. OK? Bootstrapped and tested on aarch64-linux-gnu with no regressions. gcc/ChangeLog: * config/aarch64/aarch64-builtins.c (struct aarch64_simd_type_info): Mark with GTY. (aarch64_simd_types): Likewise. (aarch64_simd_intOI_type_node): Likewise. (aarch64_simd_intCI_type_node): Likewise. (aarch64_simd_intXI_type_node): Likewise. * config/aarch64/aarch64.h (aarch64_fp16_type_node): Likewise. (aarch64_fp16_ptr_type_node): Likewise. (aarch64_bf16_type_node): Likewise. (aarch64_bf16_ptr_type_node): Likewise. Diff: --- gcc/config/aarch64/aarch64-builtins.c | 10 +++++----- gcc/config/aarch64/aarch64.h | 8 ++++---- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/gcc/config/aarch64/aarch64-builtins.c b/gcc/config/aarch64/aarch64-builtins.c index f6b41d9c200..eef9fc0f444 100644 --- a/gcc/config/aarch64/aarch64-builtins.c +++ b/gcc/config/aarch64/aarch64-builtins.c @@ -593,7 +593,7 @@ enum aarch64_simd_type }; #undef ENTRY -struct aarch64_simd_type_info +struct GTY(()) aarch64_simd_type_info { enum aarch64_simd_type type; @@ -625,14 +625,14 @@ struct aarch64_simd_type_info #define ENTRY(E, M, Q, G) \ {E, "__" #E, #G "__" #E, NULL_TREE, NULL_TREE, E_##M##mode, qualifier_##Q}, -static struct aarch64_simd_type_info aarch64_simd_types [] = { +static GTY(()) struct aarch64_simd_type_info aarch64_simd_types [] = { #include "aarch64-simd-builtin-types.def" }; #undef ENTRY -static tree aarch64_simd_intOI_type_node = NULL_TREE; -static tree aarch64_simd_intCI_type_node = NULL_TREE; -static tree aarch64_simd_intXI_type_node = NULL_TREE; +static GTY(()) tree aarch64_simd_intOI_type_node = NULL_TREE; +static GTY(()) tree aarch64_simd_intCI_type_node = NULL_TREE; +static GTY(()) tree aarch64_simd_intXI_type_node = NULL_TREE; /* The user-visible __fp16 type, and a pointer to that type. Used across the back-end. */ diff --git a/gcc/config/aarch64/aarch64.h b/gcc/config/aarch64/aarch64.h index bfffbcd6abf..a5ba6c24037 100644 --- a/gcc/config/aarch64/aarch64.h +++ b/gcc/config/aarch64/aarch64.h @@ -1262,13 +1262,13 @@ extern const char *host_detect_local_cpu (int argc, const char **argv); /* This type is the user-visible __fp16, and a pointer to that type. We need it in many places in the backend. Defined in aarch64-builtins.c. */ -extern tree aarch64_fp16_type_node; -extern tree aarch64_fp16_ptr_type_node; +extern GTY(()) tree aarch64_fp16_type_node; +extern GTY(()) tree aarch64_fp16_ptr_type_node; /* This type is the user-visible __bf16, and a pointer to that type. Defined in aarch64-builtins.c. */ -extern tree aarch64_bf16_type_node; -extern tree aarch64_bf16_ptr_type_node; +extern GTY(()) tree aarch64_bf16_type_node; +extern GTY(()) tree aarch64_bf16_ptr_type_node; /* The generic unwind code in libgcc does not initialize the frame pointer. So in order to unwind a function using a frame pointer, the very first