From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2152) id 2561A3858023; Tue, 7 Sep 2021 20:37:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2561A3858023 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Hans-Peter Nilsson To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-3393] Fix fatal typo in gcc.dg/no_profile_instrument_function-attr-2.c X-Act-Checkin: gcc X-Git-Author: Hans-Peter Nilsson X-Git-Refname: refs/heads/master X-Git-Oldrev: 2a1537a19cb2fa85823cfa18ed40baa4b259b4e3 X-Git-Newrev: 578cd82af71f978c7ffe5f50d9568df21beb25c4 Message-Id: <20210907203725.2561A3858023@sourceware.org> Date: Tue, 7 Sep 2021 20:37:25 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Sep 2021 20:37:25 -0000 https://gcc.gnu.org/g:578cd82af71f978c7ffe5f50d9568df21beb25c4 commit r12-3393-g578cd82af71f978c7ffe5f50d9568df21beb25c4 Author: Hans-Peter Nilsson Date: Tue Sep 7 22:08:49 2021 +0200 Fix fatal typo in gcc.dg/no_profile_instrument_function-attr-2.c Dejagnu is unfortunately brittle: a syntax error in a directive can abort the test-run for the current "tool" (gcc, g++, gfortran), and if you don't check for this condition or actually read the stdout log yourself, your tools may make you believe the test was successful without regressions. At the very least, always grep for ^ERROR: in the stdout log! With r12-3379, the testsuite got such a fatal syntax error, causing the gcc test-run to abort at (e.g.): ... FAIL: gcc.dg/memchr.c (test for excess errors) FAIL: gcc.dg/memcmp-3.c (test for excess errors) ERROR: (DejaGnu) proc "scan-tree-dump-not\" = foo {\(\)"} optimized" does not exist. The error code is TCL LOOKUP COMMAND scan-tree-dump-not\" The info on the error is: invalid command name "scan-tree-dump-not"" while executing "::tcl_unknown scan-tree-dump-not\" = foo {\(\)"} optimized" ("uplevel" body line 1) invoked from within "uplevel 1 ::tcl_unknown $args" === gcc Summary === # of expected passes 63740 # of unexpected failures 38 # of unexpected successes 2 # of expected failures 351 # of unresolved testcases 3 # of unsupported tests 662 x/cris-elf/gccobj/gcc/xgcc version 12.0.0 20210907 (experimental)\ [master r12-3391-g849d5f5929fc] (GCC) testsuite: * gcc.dg/no_profile_instrument_function-attr-2.c: Fix typo in last change. Diff: --- gcc/testsuite/gcc.dg/no_profile_instrument_function-attr-2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/testsuite/gcc.dg/no_profile_instrument_function-attr-2.c b/gcc/testsuite/gcc.dg/no_profile_instrument_function-attr-2.c index 472eca88efd..2e93ee5f689 100644 --- a/gcc/testsuite/gcc.dg/no_profile_instrument_function-attr-2.c +++ b/gcc/testsuite/gcc.dg/no_profile_instrument_function-attr-2.c @@ -12,4 +12,4 @@ int bar() return foo(); } -/* { dg-final { scan-tree-dump-not" = foo \\(\\)" "optimized"} } */ +/* { dg-final { scan-tree-dump-not " = foo \\(\\)" "optimized"} } */