public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Eric Botcazou <ebotcazou@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r11-9050] Fix ICE with stack checking emulation at -O2
Date: Fri,  1 Oct 2021 08:59:17 +0000 (GMT)	[thread overview]
Message-ID: <20211001085917.943933857C5B@sourceware.org> (raw)

https://gcc.gnu.org/g:3aaa884141f832b9a678d44a80e2ececfc9fc090

commit r11-9050-g3aaa884141f832b9a678d44a80e2ececfc9fc090
Author: Eric Botcazou <ebotcazou@adacore.com>
Date:   Fri Oct 1 10:56:45 2021 +0200

    Fix ICE with stack checking emulation at -O2
    
    On bare-metal platforms, the Ada compiler emulates stack checking (it is
    required by the language and tested by ACATS) in the runtime via the
    stack_check_libfunc hook of the RTL middle-end.  Calls to the function
    are generated as libcalls but they now require a proper function type
    at -O2 or above.
    
    gcc/
            * explow.c: Include langhooks.h.
            (set_stack_check_libfunc): Build a proper function type.

Diff:
---
 gcc/explow.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/gcc/explow.c b/gcc/explow.c
index b6da277f689..a35423f5d16 100644
--- a/gcc/explow.c
+++ b/gcc/explow.c
@@ -34,6 +34,7 @@ along with GCC; see the file COPYING3.  If not see
 #include "recog.h"
 #include "diagnostic-core.h"
 #include "stor-layout.h"
+#include "langhooks.h"
 #include "except.h"
 #include "dojump.h"
 #include "explow.h"
@@ -1641,8 +1642,14 @@ set_stack_check_libfunc (const char *libfunc_name)
 {
   gcc_assert (stack_check_libfunc == NULL_RTX);
   stack_check_libfunc = gen_rtx_SYMBOL_REF (Pmode, libfunc_name);
+  tree ptype
+    = Pmode == ptr_mode
+      ? ptr_type_node
+      : lang_hooks.types.type_for_mode (Pmode, 1);
+  tree ftype
+    = build_function_type_list (void_type_node, ptype, NULL_TREE);
   tree decl = build_decl (UNKNOWN_LOCATION, FUNCTION_DECL,
-			  get_identifier (libfunc_name), void_type_node);
+			  get_identifier (libfunc_name), ftype);
   DECL_EXTERNAL (decl) = 1;
   SET_SYMBOL_REF_DECL (stack_check_libfunc, decl);
 }


                 reply	other threads:[~2021-10-01  8:59 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211001085917.943933857C5B@sourceware.org \
    --to=ebotcazou@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).