From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1666) id 3A32E3858410; Tue, 5 Oct 2021 14:37:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3A32E3858410 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Richard Biener To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-4187] Allow more kinds of invariant addresses in GIMPLE FE X-Act-Checkin: gcc X-Git-Author: Richard Biener X-Git-Refname: refs/heads/master X-Git-Oldrev: f3930418cb82000fae3cb4e98e870428800cf295 X-Git-Newrev: d4f6dbe18374385b8199ca3d6121e37a1189b589 Message-Id: <20211005143746.3A32E3858410@sourceware.org> Date: Tue, 5 Oct 2021 14:37:46 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Oct 2021 14:37:46 -0000 https://gcc.gnu.org/g:d4f6dbe18374385b8199ca3d6121e37a1189b589 commit r12-4187-gd4f6dbe18374385b8199ca3d6121e37a1189b589 Author: Richard Biener Date: Tue Oct 5 14:18:09 2021 +0200 Allow more kinds of invariant addresses in GIMPLE FE The gimple FE is too restrictive in what it accepts as literals, the following makes it also accept &a[10] for example. 2021-10-05 Richard Biener PR c/102605 gcc/c/ * gimple-parser.c (c_parser_gimple_postfix_expression): Accept more address _Literals. gcc/testsuite/ * gcc.dg/gimplefe-46.c: New testcase. Diff: --- gcc/c/gimple-parser.c | 14 +++++++++----- gcc/testsuite/gcc.dg/gimplefe-46.c | 23 +++++++++++++++++++++++ 2 files changed, 32 insertions(+), 5 deletions(-) diff --git a/gcc/c/gimple-parser.c b/gcc/c/gimple-parser.c index c8d9db61f0a..c43ee38a2cf 100644 --- a/gcc/c/gimple-parser.c +++ b/gcc/c/gimple-parser.c @@ -1622,16 +1622,20 @@ c_parser_gimple_postfix_expression (gimple_parser &parser) tree val = c_parser_gimple_postfix_expression (parser).value; if (! val || val == error_mark_node - || (!CONSTANT_CLASS_P (val) - && !(addr_p - && (TREE_CODE (val) == STRING_CST - || DECL_P (val))))) + || (!CONSTANT_CLASS_P (val) && !addr_p)) { c_parser_error (parser, "invalid _Literal"); return expr; } if (addr_p) - val = build1 (ADDR_EXPR, type, val); + { + val = build1 (ADDR_EXPR, type, val); + if (!is_gimple_invariant_address (val)) + { + c_parser_error (parser, "invalid _Literal"); + return expr; + } + } if (neg_p) { val = const_unop (NEGATE_EXPR, TREE_TYPE (val), val); diff --git a/gcc/testsuite/gcc.dg/gimplefe-46.c b/gcc/testsuite/gcc.dg/gimplefe-46.c new file mode 100644 index 00000000000..fb91f7d2a90 --- /dev/null +++ b/gcc/testsuite/gcc.dg/gimplefe-46.c @@ -0,0 +1,23 @@ +/* { dg-do compile } */ +/* { dg-options "-fgimple" } */ + +char global[10]; + +void bar (void); + +void __GIMPLE (ssa) +foo (char * p) +{ + __BB(2): + if (p_2(D) == _Literal (char *)&global[2]) + goto __BB3; + else + goto __BB4; + + __BB(3): + bar (); + goto __BB4; + + __BB(4): + return; +}