public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Richard Biener <rguenth@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r12-4225] tree-optimization/102608 - avoid CSEing .DEFERRED_INIT
Date: Thu,  7 Oct 2021 12:28:25 +0000 (GMT)	[thread overview]
Message-ID: <20211007122825.C6D1A3858C60@sourceware.org> (raw)

https://gcc.gnu.org/g:1ebf2c14c60f5f37c00bea66aba46c25d4bcf473

commit r12-4225-g1ebf2c14c60f5f37c00bea66aba46c25d4bcf473
Author: Richard Biener <rguenther@suse.de>
Date:   Thu Oct 7 14:24:03 2021 +0200

    tree-optimization/102608 - avoid CSEing .DEFERRED_INIT
    
    This makes VN not CSE .DEFERRED_INIT which confuses uninit
    analysis which reports the wrong decl when facing copies
    of not initialized data.
    
    2021-10-07  Richard Biener  <rguenther@suse.de>
    
            PR tree-optimization/102608
            * tree-ssa-sccvn.c (visit_stmt): Drop .DEFERRED_INIT to
            varying.

Diff:
---
 gcc/tree-ssa-sccvn.c | 45 ++++++++++++++++++++++++---------------------
 1 file changed, 24 insertions(+), 21 deletions(-)

diff --git a/gcc/tree-ssa-sccvn.c b/gcc/tree-ssa-sccvn.c
index 0d942218279..ae0172a143e 100644
--- a/gcc/tree-ssa-sccvn.c
+++ b/gcc/tree-ssa-sccvn.c
@@ -5668,27 +5668,30 @@ visit_stmt (gimple *stmt, bool backedges_varying_p = false)
 	      && TREE_CODE (TREE_OPERAND (fn, 0)) == FUNCTION_DECL)
 	    extra_fnflags = flags_from_decl_or_type (TREE_OPERAND (fn, 0));
 	}
-      if (/* Calls to the same function with the same vuse
-	     and the same operands do not necessarily return the same
-	     value, unless they're pure or const.  */
-	  ((gimple_call_flags (call_stmt) | extra_fnflags)
-	   & (ECF_PURE | ECF_CONST))
-	  /* If calls have a vdef, subsequent calls won't have
-	     the same incoming vuse.  So, if 2 calls with vdef have the
-	     same vuse, we know they're not subsequent.
-	     We can value number 2 calls to the same function with the
-	     same vuse and the same operands which are not subsequent
-	     the same, because there is no code in the program that can
-	     compare the 2 values...  */
-	  || (gimple_vdef (call_stmt)
-	      /* ... unless the call returns a pointer which does
-		 not alias with anything else.  In which case the
-		 information that the values are distinct are encoded
-		 in the IL.  */
-	      && !(gimple_call_return_flags (call_stmt) & ERF_NOALIAS)
-	      /* Only perform the following when being called from PRE
-		 which embeds tail merging.  */
-	      && default_vn_walk_kind == VN_WALK))
+      if ((/* Calls to the same function with the same vuse
+	      and the same operands do not necessarily return the same
+	      value, unless they're pure or const.  */
+	   ((gimple_call_flags (call_stmt) | extra_fnflags)
+	    & (ECF_PURE | ECF_CONST))
+	   /* If calls have a vdef, subsequent calls won't have
+	      the same incoming vuse.  So, if 2 calls with vdef have the
+	      same vuse, we know they're not subsequent.
+	      We can value number 2 calls to the same function with the
+	      same vuse and the same operands which are not subsequent
+	      the same, because there is no code in the program that can
+	      compare the 2 values...  */
+	   || (gimple_vdef (call_stmt)
+	       /* ... unless the call returns a pointer which does
+		  not alias with anything else.  In which case the
+		  information that the values are distinct are encoded
+		  in the IL.  */
+	       && !(gimple_call_return_flags (call_stmt) & ERF_NOALIAS)
+	       /* Only perform the following when being called from PRE
+		  which embeds tail merging.  */
+	       && default_vn_walk_kind == VN_WALK))
+	  /* Do not process .DEFERRED_INIT since that confuses uninit
+	     analysis.  */
+	  && !gimple_call_internal_p (call_stmt, IFN_DEFERRED_INIT))
 	changed = visit_reference_op_call (lhs, call_stmt);
       else
 	changed = defs_to_varying (call_stmt);


                 reply	other threads:[~2021-10-07 12:28 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211007122825.C6D1A3858C60@sourceware.org \
    --to=rguenth@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).