public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Martin Jambor <jamborm@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-4230] ipa: Fix ICE when speculating calls from inlined functions (PR 102388) Date: Thu, 7 Oct 2021 14:22:19 +0000 (GMT) [thread overview] Message-ID: <20211007142219.9B72F3858C60@sourceware.org> (raw) https://gcc.gnu.org/g:1a7d452c092be42a892d00c19561af10f42410b0 commit r12-4230-g1a7d452c092be42a892d00c19561af10f42410b0 Author: Martin Jambor <mjambor@suse.cz> Date: Thu Oct 7 16:21:19 2021 +0200 ipa: Fix ICE when speculating calls from inlined functions (PR 102388) The code handling various cases which lead to call graph edge duplication (in order to update reference descriptions used to track and remove no-longer needed references) has missed one important case. When edge duplication is an effect of creating a speculative edge for an indirect edge which carries a constant jump function which had been created from a pass-through function when the edge caller has was inlined into one of its callers, the reference description attached to the function describes an edge higher up in the "inlined" clone tree and so even the new speculative edge will. Therefore we should not try to duplicate the reference description itself but rather just bump the refcount of the existing one. gcc/ChangeLog: 2021-09-22 Martin Jambor <mjambor@suse.cz> PR ipa/102388 * ipa-prop.c (ipa_edge_args_sum_t::duplicate): Also handle the case when the source reference description corresponds to a referance taken in a function src->caller is inlined to. Diff: --- gcc/ipa-prop.c | 40 +++++++++++++++++++++++++++------------- 1 file changed, 27 insertions(+), 13 deletions(-) diff --git a/gcc/ipa-prop.c b/gcc/ipa-prop.c index 1c69d9766c5..443f21ce61b 100644 --- a/gcc/ipa-prop.c +++ b/gcc/ipa-prop.c @@ -4428,19 +4428,33 @@ ipa_edge_args_sum_t::duplicate (cgraph_edge *src, cgraph_edge *dst, dst_jf->value.constant.rdesc = NULL; else if (src->caller == dst->caller) { - struct ipa_ref *ref; - symtab_node *n = symtab_node_for_jfunc (src_jf); - gcc_checking_assert (n); - ref = src->caller->find_reference (n, src->call_stmt, - src->lto_stmt_uid); - gcc_checking_assert (ref); - dst->caller->clone_reference (ref, ref->stmt); - - struct ipa_cst_ref_desc *dst_rdesc = ipa_refdesc_pool.allocate (); - dst_rdesc->cs = dst; - dst_rdesc->refcount = src_rdesc->refcount; - dst_rdesc->next_duplicate = NULL; - dst_jf->value.constant.rdesc = dst_rdesc; + /* Creation of a speculative edge. If the source edge is the one + grabbing a reference, we must create a new (duplicate) + reference description. Otherwise they refer to the same + description corresponding to a reference taken in a function + src->caller is inlined to. In that case we just must + increment the refcount. */ + if (src_rdesc->cs == src) + { + symtab_node *n = symtab_node_for_jfunc (src_jf); + gcc_checking_assert (n); + ipa_ref *ref + = src->caller->find_reference (n, src->call_stmt, + src->lto_stmt_uid); + gcc_checking_assert (ref); + dst->caller->clone_reference (ref, ref->stmt); + + ipa_cst_ref_desc *dst_rdesc = ipa_refdesc_pool.allocate (); + dst_rdesc->cs = dst; + dst_rdesc->refcount = src_rdesc->refcount; + dst_rdesc->next_duplicate = NULL; + dst_jf->value.constant.rdesc = dst_rdesc; + } + else + { + src_rdesc->refcount++; + dst_jf->value.constant.rdesc = src_rdesc; + } } else if (src_rdesc->cs == src) {
reply other threads:[~2021-10-07 14:22 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211007142219.9B72F3858C60@sourceware.org \ --to=jamborm@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).