public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Giuliano Belinassi <giulianob@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc(refs/users/giulianob/heads/pfe_backport)] Backport Fix PR 93242: patchable-function-entry broken on MIPS
Date: Mon, 25 Oct 2021 15:06:34 +0000 (GMT)	[thread overview]
Message-ID: <20211025150634.955483858035@sourceware.org> (raw)

https://gcc.gnu.org/g:770fcd0a31f3d557e5c79004161fa4c14fdaeced

commit 770fcd0a31f3d557e5c79004161fa4c14fdaeced
Author: Andrew Pinski <apinski@marvell.com>
Date:   Sat Jan 18 00:41:06 2020 +0000

    Backport Fix PR 93242: patchable-function-entry broken on MIPS
    
    On MIPS, .set noreorder/reorder needs to emitted around
    the nop.  The template for the nop instruction uses %(/%) to
    do that.  But default_print_patchable_function_entry uses
    fprintf rather than output_asm_insn to output the instruction.
    
    This fixes the problem by using output_asm_insn to emit the nop
    instruction.
    
    gcc/ChangeLog
    2021-10-07  Giuliano Belinassi  <gbelinassi@suse.de>
    
            Backport from mainline
            2020-01-20  Andrew Pinski  <apinski@marvell.com>
    
            PR middle-end/93242
            * targhooks.c (default_print_patchable_function_entry): use
            output_asm_insn to emit the nop instruction.

Diff:
---
 gcc/targhooks.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/targhooks.c b/gcc/targhooks.c
index aaf536acf17..185dc7b0b6b 100644
--- a/gcc/targhooks.c
+++ b/gcc/targhooks.c
@@ -1655,7 +1655,7 @@ default_print_patchable_function_entry (FILE *file,
 
   unsigned i;
   for (i = 0; i < patch_area_size; ++i)
-    fprintf (file, "\t%s\n", nop_templ);
+    output_asm_insn (nop_templ, NULL);
 }
 
 bool


             reply	other threads:[~2021-10-25 15:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-25 15:06 Giuliano Belinassi [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-10-11 20:49 Giuliano Belinassi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211025150634.955483858035@sourceware.org \
    --to=giulianob@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).