From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 7835) id 1B6C4385803B; Thu, 4 Nov 2021 14:56:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1B6C4385803B MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Jonathan Wright To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-4909] gcc/expmed.c: Ensure vector modes are tieable before extraction X-Act-Checkin: gcc X-Git-Author: Jonathan Wright X-Git-Refname: refs/heads/master X-Git-Oldrev: 2fc20260619b9f68044b7a3eb042726a382b5002 X-Git-Newrev: 4e5929e4575922015ff4634af4dea59c59a44f10 Message-Id: <20211104145624.1B6C4385803B@sourceware.org> Date: Thu, 4 Nov 2021 14:56:24 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2021 14:56:24 -0000 https://gcc.gnu.org/g:4e5929e4575922015ff4634af4dea59c59a44f10 commit r12-4909-g4e5929e4575922015ff4634af4dea59c59a44f10 Author: Jonathan Wright Date: Mon Oct 11 23:02:16 2021 +0100 gcc/expmed.c: Ensure vector modes are tieable before extraction Extracting a bitfield from a vector can be achieved by casting the vector to a new type whose elements are the same size as the desired bitfield, before generating a subreg. However, this is only an optimization if the original vector can be accessed in the new machine mode without first being copied - a condition denoted by the TARGET_MODES_TIEABLE_P hook. This patch adds a check to make sure that the vector modes are tieable before attempting to generate a subreg. This is a necessary prerequisite for a subsequent patch that will introduce new machine modes for Arm Neon vector-tuple types. gcc/ChangeLog: 2021-10-11 Jonathan Wright * expmed.c (extract_bit_field_1): Ensure modes are tieable. Diff: --- gcc/expmed.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gcc/expmed.c b/gcc/expmed.c index bbdd0e71d20..4abce11b647 100644 --- a/gcc/expmed.c +++ b/gcc/expmed.c @@ -1735,7 +1735,8 @@ extract_bit_field_1 (rtx str_rtx, poly_uint64 bitsize, poly_uint64 bitnum, FOR_EACH_MODE_FROM (new_mode, new_mode) if (known_eq (GET_MODE_SIZE (new_mode), GET_MODE_SIZE (GET_MODE (op0))) && known_eq (GET_MODE_UNIT_SIZE (new_mode), GET_MODE_SIZE (tmode)) - && targetm.vector_mode_supported_p (new_mode)) + && targetm.vector_mode_supported_p (new_mode) + && targetm.modes_tieable_p (GET_MODE (op0), new_mode)) break; if (new_mode != VOIDmode) op0 = gen_lowpart (new_mode, op0);