public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jonathan Wright <jonwri01@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r12-4911] gcc/lower_subreg.c: Prevent decomposition if modes are not tieable
Date: Thu,  4 Nov 2021 14:56:34 +0000 (GMT)	[thread overview]
Message-ID: <20211104145634.5B3313858439@sourceware.org> (raw)

https://gcc.gnu.org/g:511245325a4d3414a951e2d489112e8372eae1b1

commit r12-4911-g511245325a4d3414a951e2d489112e8372eae1b1
Author: Jonathan Wright <jonathan.wright@arm.com>
Date:   Thu Oct 14 13:49:02 2021 +0100

    gcc/lower_subreg.c: Prevent decomposition if modes are not tieable
    
    Preventing decomposition if modes are not tieable is necessary to
    stop AArch64 partial Neon structure modes being treated as packed in
    registers.
    
    This is a necessary prerequisite for a future AArch64 PCS change to
    maintain good code generation.
    
    gcc/ChangeLog:
    
    2021-10-14  Jonathan Wright  <jonathan.wright@arm.com>
    
            * lower-subreg.c (simple_move): Prevent decomposition if
            modes are not tieable.

Diff:
---
 gcc/lower-subreg.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gcc/lower-subreg.c b/gcc/lower-subreg.c
index 21078268ba0..f0dc63f485f 100644
--- a/gcc/lower-subreg.c
+++ b/gcc/lower-subreg.c
@@ -383,8 +383,10 @@ simple_move (rtx_insn *insn, bool speed_p)
      non-integer mode for which there is no integer mode of the same
      size.  */
   mode = GET_MODE (SET_DEST (set));
+  scalar_int_mode int_mode;
   if (!SCALAR_INT_MODE_P (mode)
-      && !int_mode_for_size (GET_MODE_BITSIZE (mode), 0).exists ())
+      && (!int_mode_for_size (GET_MODE_BITSIZE (mode), 0).exists (&int_mode)
+	  || !targetm.modes_tieable_p (mode, int_mode)))
     return NULL_RTX;
 
   /* Reject PARTIAL_INT modes.  They are used for processor specific


                 reply	other threads:[~2021-11-04 14:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211104145634.5B3313858439@sourceware.org \
    --to=jonwri01@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).