public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Richard Biener <rguenth@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-5001] Fix spurious valgrind errors in irred loop verification Date: Mon, 8 Nov 2021 15:19:48 +0000 (GMT) [thread overview] Message-ID: <20211108151948.0E34F385843F@sourceware.org> (raw) https://gcc.gnu.org/g:d626fe77cdc40de0ae1651c8b94090eea73a719f commit r12-5001-gd626fe77cdc40de0ae1651c8b94090eea73a719f Author: Richard Biener <rguenther@suse.de> Date: Mon Nov 8 15:21:08 2021 +0100 Fix spurious valgrind errors in irred loop verification The sbitmap bitmap_{set,clear}_bit changes trigger spurious uninit value use reportings from valgrind since we now read the old value before setting/clearing a bit so verify_loop_structures optimization to not clear the sbitmap is reported. Fixed by using a temporary BB flag which should also be more efficient in terms of cache re-use. 2021-11-08 Richard Biener <rguenther@suse.de> * cfgloop.c (verify_loop_structure): Use a temporary BB flag instead of an sbitmap to cache irreducible state. Diff: --- gcc/cfgloop.c | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/gcc/cfgloop.c b/gcc/cfgloop.c index 2ba9918bfa2..20c24c13c36 100644 --- a/gcc/cfgloop.c +++ b/gcc/cfgloop.c @@ -1567,19 +1567,17 @@ verify_loop_structure (void) /* Check irreducible loops. */ if (loops_state_satisfies_p (LOOPS_HAVE_MARKED_IRREDUCIBLE_REGIONS)) { - auto_edge_flag saved_irr_mask (cfun); - /* Record old info. */ - auto_sbitmap irreds (last_basic_block_for_fn (cfun)); + auto_edge_flag saved_edge_irr (cfun); + auto_bb_flag saved_bb_irr (cfun); + /* Save old info. */ FOR_EACH_BB_FN (bb, cfun) { edge_iterator ei; if (bb->flags & BB_IRREDUCIBLE_LOOP) - bitmap_set_bit (irreds, bb->index); - else - bitmap_clear_bit (irreds, bb->index); + bb->flags |= saved_bb_irr; FOR_EACH_EDGE (e, ei, bb->succs) if (e->flags & EDGE_IRREDUCIBLE_LOOP) - e->flags |= saved_irr_mask; + e->flags |= saved_edge_irr; } /* Recount it. */ @@ -1591,34 +1589,35 @@ verify_loop_structure (void) edge_iterator ei; if ((bb->flags & BB_IRREDUCIBLE_LOOP) - && !bitmap_bit_p (irreds, bb->index)) + && !(bb->flags & saved_bb_irr)) { error ("basic block %d should be marked irreducible", bb->index); err = 1; } else if (!(bb->flags & BB_IRREDUCIBLE_LOOP) - && bitmap_bit_p (irreds, bb->index)) + && (bb->flags & saved_bb_irr)) { error ("basic block %d should not be marked irreducible", bb->index); err = 1; } + bb->flags &= ~saved_bb_irr; FOR_EACH_EDGE (e, ei, bb->succs) { if ((e->flags & EDGE_IRREDUCIBLE_LOOP) - && !(e->flags & saved_irr_mask)) + && !(e->flags & saved_edge_irr)) { error ("edge from %d to %d should be marked irreducible", e->src->index, e->dest->index); err = 1; } else if (!(e->flags & EDGE_IRREDUCIBLE_LOOP) - && (e->flags & saved_irr_mask)) + && (e->flags & saved_edge_irr)) { error ("edge from %d to %d should not be marked irreducible", e->src->index, e->dest->index); err = 1; } - e->flags &= ~saved_irr_mask; + e->flags &= ~saved_edge_irr; } } }
reply other threads:[~2021-11-08 15:19 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211108151948.0E34F385843F@sourceware.org \ --to=rguenth@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).