public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jan Hubicka <hubicka@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r12-5007] Remove workaround allowing interposition of nested functions.
Date: Mon,  8 Nov 2021 17:59:04 +0000 (GMT)	[thread overview]
Message-ID: <20211108175904.959033858D3C@sourceware.org> (raw)

https://gcc.gnu.org/g:d44d791012efda1f48ed647d1d3a1538d15d4e19

commit r12-5007-gd44d791012efda1f48ed647d1d3a1538d15d4e19
Author: Jan Hubicka <hubicka@ucw.cz>
Date:   Mon Nov 8 18:58:03 2021 +0100

    Remove workaround allowing interposition of nested functions.
    
            * gimple.c (gimple_call_static_chain_flags): Revert the workaround
            allowing interposition since issues with binds_to_local_def were
            hopefully solved.

Diff:
---
 gcc/gimple.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gcc/gimple.c b/gcc/gimple.c
index 3d1d3a15b2c..9e65fa61c73 100644
--- a/gcc/gimple.c
+++ b/gcc/gimple.c
@@ -1645,13 +1645,13 @@ gimple_call_static_chain_flags (const gcall *stmt)
       modref_summary *summary = node ? get_modref_function_summary (node)
 				: NULL;
 
+      /* Nested functions should always bind to current def since
+	 there is no public ABI for them.  */
+      gcc_checking_assert (node->binds_to_current_def_p ());
       if (summary)
 	{
 	  int modref_flags = summary->static_chain_flags;
 
-	  /* ??? Nested functions should always bind to current def.  */
-	  if (!node->binds_to_current_def_p ())
-	    modref_flags = interposable_eaf_flags (modref_flags, flags);
 	  if (dbg_cnt (ipa_mod_ref_pta))
 	    flags |= modref_flags;
 	}


                 reply	other threads:[~2021-11-08 17:59 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211108175904.959033858D3C@sourceware.org \
    --to=hubicka@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).