From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pmderodat@sourceware.org>
Received: by sourceware.org (Postfix, from userid 1914)
 id 297003858000; Tue,  9 Nov 2021 09:46:46 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 297003858000
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
From: Pierre-Marie de Rodat <pmderodat@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r12-5031] [Ada] Cleanup copying of parameter lists
X-Act-Checkin: gcc
X-Git-Author: Piotr Trojanek <trojanek@adacore.com>
X-Git-Refname: refs/heads/master
X-Git-Oldrev: b064f139e3edfc7d9ed294ee8feccda2330d2ccb
X-Git-Newrev: 7751c73202f1f1336769607b0cd5cf516e29089a
Message-Id: <20211109094646.297003858000@sourceware.org>
Date: Tue,  9 Nov 2021 09:46:46 +0000 (GMT)
X-BeenThere: gcc-cvs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-cvs mailing list <gcc-cvs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-cvs>,
 <mailto:gcc-cvs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-cvs/>
List-Help: <mailto:gcc-cvs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-cvs>,
 <mailto:gcc-cvs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Nov 2021 09:46:46 -0000

https://gcc.gnu.org/g:7751c73202f1f1336769607b0cd5cf516e29089a

commit r12-5031-g7751c73202f1f1336769607b0cd5cf516e29089a
Author: Piotr Trojanek <trojanek@adacore.com>
Date:   Wed Oct 27 20:58:37 2021 +0200

    [Ada] Cleanup copying of parameter lists
    
    gcc/ada/
    
            * sem_util.adb (Copy_Parameter_List): Refactor to remove
            repeated calls to First_Formal.

Diff:
---
 gcc/ada/sem_util.adb | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/gcc/ada/sem_util.adb b/gcc/ada/sem_util.adb
index 8785e2e140c..bc51a60ccf2 100644
--- a/gcc/ada/sem_util.adb
+++ b/gcc/ada/sem_util.adb
@@ -6797,14 +6797,11 @@ package body Sem_Util is
    function Copy_Parameter_List (Subp_Id : Entity_Id) return List_Id is
       Loc    : constant Source_Ptr := Sloc (Subp_Id);
       Plist  : List_Id;
-      Formal : Entity_Id;
+      Formal : Entity_Id := First_Formal (Subp_Id);
 
    begin
-      if No (First_Formal (Subp_Id)) then
-         return No_List;
-      else
-         Plist  := New_List;
-         Formal := First_Formal (Subp_Id);
+      if Present (Formal) then
+         Plist := New_List;
          while Present (Formal) loop
             Append_To (Plist,
               Make_Parameter_Specification (Loc,
@@ -6819,6 +6816,8 @@ package body Sem_Util is
 
             Next_Formal (Formal);
          end loop;
+      else
+         Plist := No_List;
       end if;
 
       return Plist;