public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r12-5054] c++: Fix ICE on complex constant with -frounding-math [PR103114]
Date: Tue,  9 Nov 2021 14:30:14 +0000 (GMT)	[thread overview]
Message-ID: <20211109143014.EA0813858C3A@sourceware.org> (raw)

https://gcc.gnu.org/g:0318df0ae63e47f6b2f30e96205d00dcb3696538

commit r12-5054-g0318df0ae63e47f6b2f30e96205d00dcb3696538
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Nov 9 15:29:36 2021 +0100

    c++: Fix ICE on complex constant with -frounding-math [PR103114]
    
    The FE uses build_complex which assumes that fold_convert will fold
    value to a constant.  With -frounding-math that isn't guaranteed though.
    So, the patch instead fold_build2s COMPLEX_EXPR, which will result
    in build_complex if both arguments are constants, and otherwise
    will build COMPLEX_EXPR.
    build_zero_cst is an optimization for fold_convert (type, integer_zero_node).
    
    2021-11-09  Jakub Jelinek  <jakub@redhat.com>
    
            PR c++/103114
            * parser.c (cp_parser_userdef_numeric_literal): Use fold_build2
            with COMPLEX_EXPR arg instead of build_complex, use build_zero_cst
            instead of fold_convert from integer_zero_node.
    
            * g++.dg/ext/complex10.C: New test.

Diff:
---
 gcc/cp/parser.c                      | 5 ++---
 gcc/testsuite/g++.dg/ext/complex10.C | 5 +++++
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/gcc/cp/parser.c b/gcc/cp/parser.c
index 6061f983392..32de97b08bd 100644
--- a/gcc/cp/parser.c
+++ b/gcc/cp/parser.c
@@ -4804,9 +4804,8 @@ cp_parser_userdef_numeric_literal (cp_parser *parser)
       else /* if (id_equal (suffix_id, "il")) */
 	type = long_double_type_node;
 
-      value = build_complex (build_complex_type (type),
-			     fold_convert (type, integer_zero_node),
-			     fold_convert (type, value));
+      value = fold_build2 (COMPLEX_EXPR, build_complex_type (type),
+			   build_zero_cst (type), fold_convert (type, value));
     }
 
   if (cp_parser_uncommitted_to_tentative_parse_p (parser))
diff --git a/gcc/testsuite/g++.dg/ext/complex10.C b/gcc/testsuite/g++.dg/ext/complex10.C
new file mode 100644
index 00000000000..67dfb0c2aed
--- /dev/null
+++ b/gcc/testsuite/g++.dg/ext/complex10.C
@@ -0,0 +1,5 @@
+// PR c++/103114
+// { dg-do compile }
+// { dg-options "-frounding-math" }
+
+_Complex double d = 10.1i;


                 reply	other threads:[~2021-11-09 14:30 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211109143014.EA0813858C3A@sourceware.org \
    --to=jakub@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).